airship/airshipctl
Code Issues Proposed changes

Remove a duplicated unit test

Browse Source 
This drops the TestSpecifyKubeConfigInCli unit test, as it as a
duplicate of TestInitFlags.

Change-Id: I69a8f5f0151e9c8b9906c1b3076e16304c50831a
This commit is contained in:
Ian Howell 2019-11-12 15:43:41 -06:00
parent 1556a09103
commit a0751bb343
1 changed files with 4 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pkg/environment/settings_test.go
View File

@ -28,21 +28,12 @@ import (
"opendev.org/airship/airshipctl/pkg/config" "opendev.org/airship/airshipctl/pkg/config"
) )
// Bogus for coverage
func FakeCmd() *cobra.Command {
fakecmd := &cobra.Command{
Use: "fakecmd",
Run: func(cmd *cobra.Command, args []string) {},
}
return fakecmd
}
func TestInitFlags(t *testing.T) { func TestInitFlags(t *testing.T) {
// Get the Environment // Get the Environment
settings := &AirshipCTLSettings{} settings := &AirshipCTLSettings{}
fakecmd := FakeCmd() testCmd := &cobra.Command{}
settings.InitFlags(fakecmd) settings.InitFlags(testCmd)
assert.True(t, fakecmd.HasPersistentFlags()) assert.True(t, testCmd.HasPersistentFlags())
} }
func TestSpecifyAirConfigFromEnv(t *testing.T) { func TestSpecifyAirConfigFromEnv(t *testing.T) {
@ -55,6 +46,7 @@ func TestSpecifyAirConfigFromEnv(t *testing.T) {
assert.EqualValues(t, fakeConfig, settings.AirshipConfigPath()) assert.EqualValues(t, fakeConfig, settings.AirshipConfigPath())
} }
func TestGetSetPaths(t *testing.T) { func TestGetSetPaths(t *testing.T) {
settings := &AirshipCTLSettings{} settings := &AirshipCTLSettings{}
settings.InitConfig() settings.InitConfig()
@ -66,11 +58,3 @@ func TestGetSetPaths(t *testing.T) {
settings.SetKubeConfigPath(kConfigFile) settings.SetKubeConfigPath(kConfigFile)
assert.EqualValues(t, kConfigFile, settings.KubeConfigPath()) assert.EqualValues(t, kConfigFile, settings.KubeConfigPath())
} }
func TestSpecifyKubeConfigInCli(t *testing.T) {
fakecmd := FakeCmd()
settings := &AirshipCTLSettings{}
settings.InitFlags(fakecmd)
assert.True(t, fakecmd.HasPersistentFlags())
}