From aeaf823ecdc38d2bd13432b9867d0ad76863dbe0 Mon Sep 17 00:00:00 2001 From: Alexander Hughes Date: Fri, 29 Jan 2021 09:47:34 -0500 Subject: [PATCH] Bump linter from 1.29 to 1.36 Updating linter to latest version, which also updates gosec to latest version to keep on top of updated security checks in source code. To address security concerns raised by gosec with this update the MinVersion of TLS is set to 13, as expected in this update to gosec [0] [0] https://github.com/securego/gosec/commit/55d368f2e55ce21f07fe8da827956ee099e122e4 Co-Authored-By: Ian Howell Co-Authored-By: Alexander Hughes Change-Id: I18cc618d24fb6979944df45f4755f4abc3ebc421 Signed-off-by: Alexander Hughes --- pkg/webservice/server.go | 1 + tools/install_go_linter | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/webservice/server.go b/pkg/webservice/server.go index 084043c..1b7b1e5 100755 --- a/pkg/webservice/server.go +++ b/pkg/webservice/server.go @@ -92,6 +92,7 @@ func WebServer() { InsecureSkipVerify: false, ServerName: configs.UIConfig.WebService.Host, Certificates: getCertificates(), + MinVersion: tls.VersionTLS13, }, Handler: webServerMux, ErrorLog: log.Logger(), diff --git a/tools/install_go_linter b/tools/install_go_linter index 26c1996..535c26b 100755 --- a/tools/install_go_linter +++ b/tools/install_go_linter @@ -3,7 +3,7 @@ set -x tools_bin_dir="${BASH_SOURCE%/*}" download_url=https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh -version=v1.27.0 +version=v1.36.0 if ! curl -sfL "$download_url" | sh -s -- -b "$tools_bin_dir/bin" "$version"; then printf "Something went wrong while installing golangci-lint\n" 1>&2