From c8d01637b0678d9f1bb16b54491822294d88f5a9 Mon Sep 17 00:00:00 2001
From: Clark Boylan <clark.boylan@gmail.com>
Date: Tue, 10 Sep 2019 15:52:26 -0700
Subject: [PATCH] Update cleanup tasks to only happen on failure

To reduce noise in logs and job overhead only collect last effort debug
info when jobs fail. This should make jobs run more quickly and keep
logs cleaner.

Change-Id: Id62986e5801ddbb46665985766f93a34b462c321
---
 playbooks/base-test/cleanup.yaml | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/playbooks/base-test/cleanup.yaml b/playbooks/base-test/cleanup.yaml
index 18e3dc0..719e6d2 100644
--- a/playbooks/base-test/cleanup.yaml
+++ b/playbooks/base-test/cleanup.yaml
@@ -1,13 +1,16 @@
 - hosts: all
   tasks:
-    - name: get df disk usage
-      raw: df
+    - name: Gather debug info on job fail
+      when: not (zuul_success | bool)
+      block:
+        - name: get df disk usage
+          raw: df
 
-    - name: get df inode usage
-      raw: df -i
+        - name: get df inode usage
+          raw: df -i
 
-    - name: get l2 networking
-      raw: ip link
+        - name: get l2 networking
+          raw: ip link
 
-    - name: get l3 networking
-      raw: ip addr
+        - name: get l3 networking
+          raw: ip addr