opendev/elastic-recheck
Code Issues Proposed changes

Interpolate strings using logging own methods

Browse Source 
String interpolation should be delayed to be handled by the logging code, 
rather than being done at the point of the logging call. 
Ref:http://docs.openstack.org/developer/oslo.i18n/guidelines.html#log-translation
For example:
# WRONG
LOG.info(_LI('some message: variable=%s') % variable)
# RIGHT
LOG.info(_LI('some message: variable=%s'), variable)

Change-Id: I44b85cbf9f4b27d1fee2c1465029fca8cde4f87e
This commit is contained in:
zhangyanxian 2016-11-08 01:49:11 +00:00
parent 3afc6e6729
commit 0348b7e001
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
elastic_recheck/cmd/uncategorized_fails.py
View File

@ -354,7 +354,7 @@ def main():
LOG.info("Starting search for unclassified failures")
for group in all_gate_fails:
LOG.info("Processing failures for group: %s" % group)
LOG.info("Processing failures for group: %s", group)
fails = all_gate_fails[group]
if not fails:
continue