opendev/elastic-recheck
Code Issues Proposed changes

Fix test_files_at_url_pass

Browse Source 
Previously there would be an error from mox related to urlopen in
test_files_at_url_pass causing the test to fail. This commit gets
around it by stubbing out url open instead of using mox.

Change-Id: I1405862151f97ebfaa2cf22fd993cbc5f07e7b0c
This commit is contained in:
Matthew Treinish 2013-10-09 13:58:33 -04:00
parent ac8a3feacd
commit 12835a2d73
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
elastic_recheck/tests/unit/test_required_files.py
View File

@ -24,10 +24,12 @@ class TestRequiredFiles(tests.TestCase):
self.assertEqual(url,
'http://logs.openstack.org/13/46613/2/check/gate-tempest-devstack-vm-full/864bf44')
def _fake_urlopen(self, url):
pass
def test_files_at_url_pass(self):
self.mox.StubOutWithMock(urllib2, 'urlopen')
self.stubs.Set(urllib2, 'urlopen', self._fake_urlopen)
result = elasticRecheck.RequiredFiles.files_at_url('http://logs.openstack.org/13/46613/2/check/gate-tempest-devstack-vm-full/864bf44')
self.mox.ReplayAll()
self.assertTrue(result)
def _invalid_url_open(self, url):