opendev/elastic-recheck
Code Issues Proposed changes

Fix kibana3 url quoting

Browse Source 
Kibana 3 is special and wants its parameters url quoted and not
urlencoded. The major problem is that it doesn't treat +'s as spaces
which urlencoding does. It wants spaces as %20 which quoting will do.

Change-Id: Ia0f50401a038e789b67499df51acbc68fe12878c
This commit is contained in:
Clark Boylan 2015-10-16 12:18:01 -07:00
parent a51fe27ba4
commit f0b9929ab2
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
elastic_recheck/query_builder.py
View File

@ -19,7 +19,7 @@ by elastic recheck to talk with elastic search.
""" """
import json import json
from six.moves.urllib.parse import urlencode from six.moves.urllib.parse import quote as urlquote
def generic(raw_query, facet=None): def generic(raw_query, facet=None):
@ -139,6 +139,9 @@ def encode_logstash_query(query, timeframe=864000):
# things like " are properly escaped. But we dont # things like " are properly escaped. But we dont
# want the outer ""s that result from dumpsing the # want the outer ""s that result from dumpsing the
# string so we strip those off again. And finally # string so we strip those off again. And finally
# the whole thing gets urlencoded. # the whole thing gets quoted to escape spaces and
# special characters. Note that kibana3 is braindead
# and expects its parameters url quoted not parameter
# encoded
query = json.dumps(query)[1:-1] query = json.dumps(query)[1:-1]
return urlencode({'query': query, 'from': timeframe}) return 'query=' + urlquote(query) + "&from=" + timeframe