opendev/gear
Code Issues Proposed changes

Merge "wakeConnections: Randomize connections before scanning them"

Browse Source
This commit is contained in:
Zuul 2021-03-10 19:41:24 +00:00 committed by Gerrit Code Review
commit 29e9d1fa99
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gear/__init__.py
View File

@ -15,6 +15,7 @@
import errno import errno
import logging import logging
import os import os
import random
import select import select
import six import six
import socket import socket
@ -3298,7 +3299,13 @@ class Server(BaseClientServer):
def wakeConnections(self, job=None): def wakeConnections(self, job=None):
p = Packet(constants.RES, constants.NOOP, b'') p = Packet(constants.RES, constants.NOOP, b'')
for connection in self.active_connections:
# Use a randomized copy of active_connections to try
# to spread workload across the machines that workers are on.
conns = self.active_connections[:]
random.shuffle(conns) # Modifies the list
for connection in conns:
if connection.state == 'SLEEP': if connection.state == 'SLEEP':
if ((job and job.name in connection.functions) or if ((job and job.name in connection.functions) or
(job is None)): (job is None)):