From 8cfa7d248652c93f5971443e6089f14773deedac Mon Sep 17 00:00:00 2001 From: Spencer Krum Date: Sun, 16 Nov 2014 16:51:51 +0000 Subject: [PATCH] Remove Modulefile from puppet-module spec In their infinite wisdom and knack for planning, Puppet has decided that the Modulefile is now deprecated and everyone should be writing metdata.json by hand. Yay.... We don't need to have these in our modules any more. I will submit patches to the ones that have them that rip them out and replace we metadata.json For anyone worried about it, I wrote a metadata.json linting ruby gem we can run over our metadata.json to make sure we don't screw it up. Change-Id: I39c2e56b916db4158885ff0ae19fc751a37e26b6 --- specs/puppet-modules.rst | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/specs/puppet-modules.rst b/specs/puppet-modules.rst index 58eb825..76b22ad 100644 --- a/specs/puppet-modules.rst +++ b/specs/puppet-modules.rst @@ -151,18 +151,6 @@ The following process must be done for each module separately: PuppetLint.configuration.send('disable_class_parameter_defaults') - * Modulefile :: - - name 'openstackci-$module' - version '0.0.1' - source 'git://git.openstack.org/openstack-infra/puppet-$module.git' - author 'Openstack CI' - license 'Apache 2.0' - summary 'Puppet module for $module' - description 'This module installs and configures $module.' - project_page 'http://ci.openstack.org/' - - * README.md :: # OpenStack $module Module @@ -188,6 +176,9 @@ The following process must be done for each module separately: we must count on the code review process to ensure that we've done this right. + # Note that the Modulefile is deprecated and we should be using metadata.json + exclusively now. + #. When dependent puppet-module splits are completely ready to merge, a core reviewer will commit to approving them in the appropriate order or coordinate with another reviewer to take over.