opendev/puppet-drupal
Code Issues Proposed changes

Add reasonable default for $site_name parameter

Browse Source 
If left undefined, the drupal class will create a vhost file named
50-.conf with an empty ServerName, and httpd will fail to start. Use
$::fqdn as a default site_name instead.

This will not affect Infra as Infra specifies this value explicitly.
Any downstream users must also be specifying this value explicitly for
the module to work, so this is a safe change.

Change-Id: Ia639f05a4ba7072812a1c4d6bb3a702fce493d02
This commit is contained in:
Colleen Murphy 2015-10-15 12:42:37 -07:00
parent 2354f29bdd
commit 9121247258
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/init.pp
View File

@ -61,7 +61,7 @@
#
class drupal (
$site_name = undef,
$site_name = $::fqdn,
$site_root = undef,
$site_docroot = "${site_root}/w",
$site_mysql_host = 'localhost',