Order of the classes parameters is refactored

Order and intendation of those parameters are changed
to follow Puppet Style Guide recommendation [0].
Moreover, it will allow to an user to find much faster
a variable in a list of variables.

[0]. https://docs.puppetlabs.com/guides/style_guide.html

Change-Id: I62834743fbe2a7cc9154c906136f6d38574f8105

manifests/backup.pp

@@ -7,13 +7,16 @@
 # /usr/bin.
 #
 define mysql_backup::backup (
-  $minute = '0',
-  $hour = '0',
-  $day = '*',
-  $dest_dir = '/var/backups/mysql_backups',
-  $rotation = 'daily',
-  $num_backups = '30',
-  $defaults_file = '/etc/mysql/debian.cnf'
+  # The parameters below are grouped in violation of style guide
+  # to save readable configuration of cron. All other parameters
+  # are grouped properly.
+  $day           = '*',
+  $hour          = '0',
+  $minute        = '0',
+  $defaults_file = '/etc/mysql/debian.cnf',
+  $dest_dir      = '/var/backups/mysql_backups',
+  $num_backups   = '30',
+  $rotation      = 'daily',
 ) {
   # Wrap in check as there may be mutliple backup defines backing
   # up to the same dir.

manifests/backup_remote.pp

@@ -8,14 +8,17 @@
 #
 define mysql_backup::backup_remote (
   $database_host,
-  $database_user,
   $database_password,
-  $minute = '0',
-  $hour = '0',
-  $day = '*',
-  $dest_dir = '/var/backups/mysql_backups',
-  $rotation = 'daily',
-  $num_backups = '30'
+  $database_user,
+  # The parameters below are grouped in violation of style guide
+  # to save readable configuration of cron. All other parameters
+  # are grouped properly.
+  $day         = '*',
+  $hour        = '0',
+  $minute      = '0',
+  $dest_dir    = '/var/backups/mysql_backups',
+  $num_backups = '30',
+  $rotation    = 'daily',
 ) {
   # Wrap in check as there may be mutliple backup defines backing
   # up to the same dir.