opendev/puppet-reviewday
Code Issues Proposed changes

Fix exec idempotency

Browse Source 
The install-reviewday-dependencies exec doesn't need to be executed on
every puppet run, only when the source repo is updated, so add a
refreshonly => true to ensure it only reacts to changes in the source
repository.

Change-Id: Id3a747e49416398e3fdde9aeb843370890dbe572
This commit is contained in:
Colleen Murphy 2018-07-11 22:58:07 +02:00
parent cb806fc80b
commit 3d9839bfa4
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
manifests/site.pp
View File

@ -83,10 +83,11 @@ define reviewday::site(
}
exec { 'install-reviewday-dependencies':
command => 'pip install -r /var/lib/reviewday/reviewday/requirements.txt',
path => '/usr/local/bin/:/bin/',
subscribe => Vcsrepo['/var/lib/reviewday/reviewday'],
require => Class['pip'],
command => 'pip install -r /var/lib/reviewday/reviewday/requirements.txt',
path => '/usr/local/bin/:/bin/',
subscribe => Vcsrepo['/var/lib/reviewday/reviewday'],
refreshonly => true,
require => Class['pip'],
}
file { $httproot: