Merge "Fix puppet-lint errors"

.gitignore

@@ -0,0 +1,2 @@
+Gemfile.lock
+.bundled_gems

Gemfile

@@ -0,0 +1,29 @@
+source 'https://rubygems.org'
+
+group :development, :test do
+  gem 'puppetlabs_spec_helper', :require => false
+
+  gem 'metadata-json-lint'
+  # This is nice and all, but let's not worry about it until we've actually
+  # got puppet 4.x sorted
+  # gem 'puppet-lint-param-docs'
+  gem 'puppet-lint-absolute_classname-check'
+  gem 'puppet-lint-absolute_template_path'
+  gem 'puppet-lint-trailing_newline-check'
+
+  # Puppet 4.x related lint checks
+  gem 'puppet-lint-unquoted_string-check'
+  #The puppet-gerrit module makes too much use of empty string defaults
+  #so disable this check for now
+  #gem 'puppet-lint-empty_string-check'
+  gem 'puppet-lint-leading_zero-check'
+  gem 'puppet-lint-variable_contains_upcase'
+  gem 'puppet-lint-spaceship_operator_without_tag-check'
+  gem 'puppet-lint-undef_in_function-check'
+
+  if puppetversion = ENV['PUPPET_GEM_VERSION']
+    gem 'puppet', puppetversion, :require => false
+  else
+    gem 'puppet', '~> 3.0', :require => false
+  end
+end

manifests/init.pp

@@ -54,7 +54,7 @@ class zuul (
   $block_referers = [],
 ) {
   include ::httpd
-  include pip
+  include ::pip
 
   $packages = [
     'gcc',  # yappi requires this to build

manifests/merger.pp

@@ -42,8 +42,8 @@ class zuul::merger (
     }
   }
 
-  include logrotate
-  logrotate::file { 'merger.log':
+  include ::logrotate
+  ::logrotate::file { 'merger.log':
     log     => '/var/log/zuul/merger.log',
     options => [
       'compress',
@@ -54,7 +54,7 @@ class zuul::merger (
     ],
     require => Service['zuul-merger'],
   }
-  logrotate::file { 'merger-debug.log':
+  ::logrotate::file { 'merger-debug.log':
     log     => '/var/log/zuul/merger-debug.log',
     options => [
       'compress',

manifests/server.pp

@@ -59,8 +59,8 @@ class zuul::server (
     }
   }
 
-  include logrotate
-  logrotate::file { 'zuul.log':
+  include ::logrotate
+  ::logrotate::file { 'zuul.log':
     log     => '/var/log/zuul/zuul.log',
     options => [
       'compress',
@@ -71,7 +71,7 @@ class zuul::server (
     ],
     require => Service['zuul'],
   }
-  logrotate::file { 'zuul-debug.log':
+  ::logrotate::file { 'zuul-debug.log':
     log     => '/var/log/zuul/debug.log',
     options => [
       'compress',