opendev/storyboard-webclient
Code Issues Proposed changes

Use icons.less for tasks, worklists, and boards

Browse Source 
This facilitates the changing of icons, by allowing the icon for
a particular resource to be changed in a central place rather than
touching many files.

Change-Id: Ie3fca5bcd7dc1ef63e99c55a427cecb820a8219d
This commit is contained in:
Adam Coldrick 2018-02-18 10:58:52 +00:00
parent 9a20857262
commit 3d22d1d0e2
9 changed files with 17 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/app/boards/template/board_contents/kanban_lane_contents.html
View File

@ -54,7 +54,7 @@
<div as-sortable-item-handle ng-switch-when="task"> <div as-sortable-item-handle ng-switch-when="task">
<div class="row"> <div class="row">
<div class="col-xs-1"> <div class="col-xs-1">
<i class="fa fa-tasks text-muted"></i> <i class="fa fa-sb-task text-muted"></i>
</div> </div>
<div class="col-xs-10"> <div class="col-xs-10">
<button type="button" class="close" title="Remove" <button type="button" class="close" title="Remove"

2
src/app/boards/template/board_contents/kanban_lane_contents_static.html
View File

@ -47,7 +47,7 @@
<div ng-switch-when="task"> <div ng-switch-when="task">
<div class="row"> <div class="row">
<div class="col-xs-1"> <div class="col-xs-1">
<i class="fa fa-tasks text-muted"></i> <i class="fa fa-sb-task text-muted"></i>
</div> </div>
<div class="col-xs-10"> <div class="col-xs-10">
<a> <a>

2
src/app/boards/template/card_details.html
View File

@ -41,7 +41,7 @@
<div class="col-xs-12 card-heading"> <div class="col-xs-12 card-heading">
<h2> <h2>
<span ng-show="!editingTitle"> <span ng-show="!editingTitle">
<i class="fa fa-tasks"></i> <i class="fa fa-sb-task"></i>
{{card.task.title}} {{card.task.title}}
<small ng-show="permissions.moveCards || permissions.editBoard"> <small ng-show="permissions.moveCards || permissions.editBoard">
<a href ng-click="toggleEditTitle()"> <a href ng-click="toggleEditTitle()">

2
src/app/dashboard/template/submenu.html
View File

@ -21,7 +21,7 @@
</li> </li>
<li active-path="^\/dashboard/boards.*"> <li active-path="^\/dashboard/boards.*">
<a href="#!/dashboard/boards" title="Boards and Worklists"> <a href="#!/dashboard/boards" title="Boards and Worklists">
<i class="fa fa-tasks fa-lg"></i> <i class="fa fa-sb-board fa-lg"></i>
</a> </a>
</li> </li>
<li active-path="^\/dashboard/subscriptions.*"> <li active-path="^\/dashboard/subscriptions.*">

6
src/app/search/template/typeahead_criteria_item.html
View File

@ -34,13 +34,13 @@
<i class="fa fa-sb-user text-muted"></i>&emsp;{{match.model.title}} <i class="fa fa-sb-user text-muted"></i>&emsp;{{match.model.title}}
</span> </span>
<span ng-switch-when="Task"> <span ng-switch-when="Task">
<i class="fa fa-tasks text-muted"></i>&emsp;{{match.model.title}} <i class="fa fa-sb-task text-muted"></i>&emsp;{{match.model.title}}
</span> </span>
<span ng-switch-when="Board"> <span ng-switch-when="Board">
<i class="fa fa-tasks text-muted"></i>&emsp;{{match.model.title}} <i class="fa fa-sb-board text-muted"></i>&emsp;{{match.model.title}}
</span> </span>
<span ng-switch-when="Worklist"> <span ng-switch-when="Worklist">
<i class="fa fa-tasks text-muted"></i>&emsp;{{match.model.title}} <i class="fa fa-sb-worklist text-muted"></i>&emsp;{{match.model.title}}
</span> </span>
<span ng-switch-default> <span ng-switch-default>
<i class="fa fa-question text-muted"></i>&emsp;{{match.model.type}} <i class="fa fa-question text-muted"></i>&emsp;{{match.model.type}}

4
src/app/storyboard/template/side_menu.html
View File

@ -44,8 +44,8 @@
</li> </li>
<li active-path="^\/board\/*"> <li active-path="^\/board\/*">
<a href="#!/board/list"> <a href="#!/board/list">
<i class="fa fa-tasks fa-lg visible-sm visible-xs"></i> <i class="fa fa-sb-board fa-lg visible-sm visible-xs"></i>
<i class="fa fa-tasks fa-3x visible-lg visible-md"></i> <i class="fa fa-sb-board fa-3x visible-lg visible-md"></i>
<small class="visible-lg visible-md">Worklists & Boards</small> <small class="visible-lg visible-md">Worklists & Boards</small>
</a> </a>
</li> </li>

8
src/app/worklists/template/additem.html
View File

@ -102,7 +102,7 @@
<i class="fa fa-sb-story text-muted"></i>&emsp;{{item.title}} <i class="fa fa-sb-story text-muted"></i>&emsp;{{item.title}}
</span> </span>
<span ng-switch-when="Task"> <span ng-switch-when="Task">
<i class="fa fa-tasks text-muted"></i>&emsp;{{item.title}} <i class="fa fa-sb-task text-muted"></i>&emsp;{{item.title}}
</span> </span>
<button type="button" class="close" title="Remove" <button type="button" class="close" title="Remove"
ng-click="removeItem(item)"> ng-click="removeItem(item)">
@ -169,7 +169,7 @@
ng-click="selectTask(task, item.tasks, $event)" ng-click="selectTask(task, item.tasks, $event)"
ng-repeat="task in item.tasks"> ng-repeat="task in item.tasks">
<td class="col-xs-11"> <td class="col-xs-11">
<i class="fa fa-tasks text-muted"></i>&emsp; <i class="fa fa-sb-task text-muted"></i>&emsp;
{{task.title}} {{task.title}}
</td> </td>
<td class="col-xs-1 text-right"> <td class="col-xs-1 text-right">
@ -194,7 +194,7 @@
ng-show="showInvalid" ng-show="showInvalid"
ng-click="$event.stopPropagation()"> ng-click="$event.stopPropagation()">
<td colspan="2"> <td colspan="2">
<i class="fa fa-tasks text-muted"></i>&emsp; <i class="fa fa-sb-task text-muted"></i>&emsp;
{{task.title}} {{task.title}}
<div class="text-muted"> <div class="text-muted">
<small>{{task.invalid}}</small> <small>{{task.invalid}}</small>
@ -211,7 +211,7 @@
<script type="text/ng-template" id="./inline/task_search_result.html"> <script type="text/ng-template" id="./inline/task_search_result.html">
<td class="col-xs-11"> <td class="col-xs-11">
<i class="fa fa-tasks text-muted"></i>&emsp; <i class="fa fa-sb-task text-muted"></i>&emsp;
{{item.title}} {{item.title}}
</td> </td>
<td class="col-xs-1 text-right"> <td class="col-xs-1 text-right">

4
src/app/worklists/template/detail.html
View File

@ -406,7 +406,7 @@
<div as-sortable-item-handle ng-switch-when="task"> <div as-sortable-item-handle ng-switch-when="task">
<div class="row"> <div class="row">
<div class="col-xs-1"> <div class="col-xs-1">
<i class="fa fa-tasks text-muted"></i> <i class="fa fa-sb-task text-muted"></i>
</div> </div>
<div class="col-xs-10"> <div class="col-xs-10">
<a href="#!/story/{{item.task.story_id}}"> <a href="#!/story/{{item.task.story_id}}">
@ -491,7 +491,7 @@
<div ng-switch-when="task"> <div ng-switch-when="task">
<div class="row"> <div class="row">
<div class="col-xs-1"> <div class="col-xs-1">
<i class="fa fa-tasks text-muted"></i> <i class="fa fa-sb-task text-muted"></i>
</div> </div>
<div class="col-xs-11"> <div class="col-xs-11">
<a href="#!/story/{{item.task.story_id}}"> <a href="#!/story/{{item.task.story_id}}">

2
src/theme/base/icons.less
View File

@ -30,3 +30,5 @@
.@{fa-css-prefix}-sb-profile:before { content: @fa-var-user; } .@{fa-css-prefix}-sb-profile:before { content: @fa-var-user; }
.@{fa-css-prefix}-sb-profile-preferences:before { content: @fa-var-gear; } .@{fa-css-prefix}-sb-profile-preferences:before { content: @fa-var-gear; }
.@{fa-css-prefix}-sb-profile-tokens:before { content: @fa-var-key; } .@{fa-css-prefix}-sb-profile-tokens:before { content: @fa-var-key; }
.@{fa-css-prefix}-sb-board:before { content: @fa-var-tasks; }
.@{fa-css-prefix}-sb-worklist:before { content: @fa-var-tasks; }