opendev/storyboard-webclient
Code Issues Proposed changes

Enhance adding tags on story details page

Browse Source 
This patch allows multiple tags to be added to stories faster by pressing the enter key and there's a tiny cross icon that can be clicked once done adding all tags. Also resolves a task where the input field needs to be cleared after adding a tag.

Change-Id: I2af4566627e544d03a9c52a1c556932c6dbb1347
Task: 6197
This commit is contained in:
Riju19 2019-03-12 09:49:29 +05:30
parent 13984cb8de
commit a1f5cc94c1
2 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/app/stories/controller/story_detail_controller.js
View File

@ -784,6 +784,7 @@ angular.module('sb.story').controller('StoryDetailController',
$scope.showAddTag = false;
$scope.toggleAddTag = function() {
$scope.newTag.name = null;
$scope.showAddTag = !$scope.showAddTag;
};
@ -794,11 +795,11 @@ angular.module('sb.story').controller('StoryDetailController',
DSCacheFactory.get('defaultCache').put(
storyboardApiBase + '/stories/' + story.id,
updatedStory);
$scope.showAddTag = false;
$scope.story.tags.push(tag_name);
$scope.loadEvents();
},
handleServiceError);
$scope.newTag.name = null;
}
};

17
src/app/stories/template/detail.html
View File

@ -366,18 +366,19 @@
<p class="text-muted" ng-if="story.tags.length == 0 && !isLoggedIn">
<em>This story has no tags yet.</em>
</p>
<span class="input-group" ng-show="showAddTag">
<input type="text" class="form-control" ng-model="newTag.name"
typeahead="tag as tag.name for tag in searchTags($viewValue)"
typeahead-on-select="updateViewValue($model.name);"/>
<div class="col-xs-3 input-group" ng-show="showAddTag">
<input type="text"
class="form-control"
ng-model="newTag.name"
typeahead="tag as tag.name for tag in searchTags($viewValue)"
typeahead-on-select="updateViewValue($model.name);"
ng-enter="addTag(newTag.name)"
focus/>
<span class="input-group-btn">
<button class="btn btn-primary" type="button"
ng-click="addTag(newTag.name)">Add</button>
<button class="btn btn-default" type="button"
ng-click="toggleAddTag()">Cancel</button>
</span>
</span>
</div>
<button class="btn btn-default" ng-click="toggleAddTag()"
ng-show="!showAddTag && isLoggedIn">
<i class="fa fa-plus-circle"></i>&nbsp;Add Tag