opendev/storyboard-webclient
Code Issues Proposed changes

Merge "Fix setting preferences when logged out"

Browse Source
This commit is contained in:
Jenkins 2015-12-09 10:29:20 +00:00 committed by Gerrit Code Review
commit cf28ac5550
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/app/services/provider/preference.js
View File

@ -184,8 +184,14 @@ angular.module('sb.services').provider('Preference',
this.save = function (isDefault) { this.save = function (isDefault) {
var deferred = $q.defer(); var deferred = $q.defer();
// Don't save default preferences, but just checking there is
// no $save() method is insufficient. Also, if there is no
// $save() method, don't try to save the preferences (this is
// the case when there is no logged in user).
if (isDefault) { if (isDefault) {
deferred.resolve(); deferred.resolve();
} else if (!preferences.$save) {
deferred.resolve();
} else { } else {
preferences.$save({id: AccessToken.getIdToken()}, preferences.$save({id: AccessToken.getIdToken()},
function () { function () {