opendev/storyboard-webclient
Code Issues Proposed changes

Added story status to project story list.

Browse Source 
I split the template for the table row item into a separate template
that's now shared between the story list and the project detail
story list.

Change-Id: I577904da07678fda13e9a3c03634a856f79b7a77
This commit is contained in:
Michael Krotscheck 2014-04-10 14:41:26 -07:00
parent 4c988ff88d
commit e3071cc725
3 changed files with 97 additions and 124 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/app/templates/project/stories.html
View File

@ -60,41 +60,15 @@
ng-hide="isSearching || stories.length == 0"> ng-hide="isSearching || stories.length == 0">
<thead> <thead>
<tr> <tr>
<th class="col-sm-1"> <th colspan="3">
<small>ID</small> &nbsp;
</th>
<th class="col-sm-7">
<small>Story Name</small>
</th>
<th class="col-sm-2 text-right">
<small>
<strong>Tasks</strong><br/>
Opened / Total
</small>
</th> </th>
</tr> </tr>
</thead> </thead>
<tbody> <tbody>
<tr ng-repeat="story in stories"> <tr ng-repeat="story in stories"
<td> ng-controller="StoryListItemController"
<p><strong> ng-include="'app/templates/story/story_list_item.html'">
<a href="#!/story/{{story.id}}">{{story.id}}</a>
</strong></p>
</td>
<td>
<p><strong>
<a href="#!/story/{{story.id}}">{{story.title}}</a>
</strong></p>
<small class="text-muted">
<span class="honor-carriage-return">{{story.description}}
</span>
</small>
</td>
<td class="text-right">
<p class="text-muted">
{{story.openTasks}} / {{story.totalTasks}}
</p>
</td>
</tr> </tr>
</tbody> </tbody>
</table> </table>

95
src/app/templates/story/list.html
View File

@ -55,102 +55,11 @@
</thead> </thead>
<tbody> <tbody>
<tr ng-repeat="story in stories" <tr ng-repeat="story in stories"
ng-controller="StoryListItemController"> ng-controller="StoryListItemController"
<td style="white-space: nowrap"> ng-include="'app/templates/story/story_list_item.html'">
<a href=""
ng-click="expandRow = !expandRow">
<i class="fa fa-caret-down"
ng-show="expandRow"></i>
<i class="fa fa-caret-right"
ng-hide="expandRow"></i>
</a>&nbsp;
<strong>
<a href="#!/story/{{story.id}}">
{{story.id}}
</a>
</strong>
</td>
<td>
<p>
<strong>
<a href="#!/story/{{story.id}}">
{{story.title}}
</a>
</strong>
<br/>
<small class="text-muted honor-carriage-return"
ng-show="expandRow">
{{story.description}}
</small>
</p>
</td>
<td class="text-right">
<p class="label {{statusLabelStyle}}"
ng-click="expandRow = !expandRow">
<i class="fa fa-caret-down"
ng-show="expandRow"></i>
<i class="fa fa-caret-right"
ng-hide="expandRow"></i>
{{story.status | capitalize}}
</p>
<table ng-show="expandRow"
class="table table-clean table-supercondensed">
<tr>
<th>
<small>Todo:</small>
</th>
<td>
<strong>
<small>{{story.todo || 0}}</small>
</strong>
</td>
</tr>
<tr class="text-info">
<th>
<small>Progress:</small>
</th>
<td>
<strong>
<small>{{story.inprogress || 0}}</small>
</strong>
</td>
</tr>
<tr class="text-warning">
<th>
<small>Review:</small>
</th>
<td>
<strong>
<small>{{story.review || 0}}</small>
</strong>
</td>
</tr>
<tr class="text-success">
<th>
<small>Merged:</small>
</th>
<td>
<strong>
<small>{{story.merged || 0}}</small>
</strong>
</td>
</tr>
<tr class="text-muted">
<th>
<small>Invalid:</small>
</th>
<td>
<strong>
<small>{{story.invalid || 0}}</small>
</strong>
</td>
</tr>
</table>
</td>
</tr> </tr>
</tbody> </tbody>
</table> </table>
</div> </div>
</div> </div>

90
src/app/templates/story/story_list_item.html Normal file
View File

@ -0,0 +1,90 @@
<td style="white-space: nowrap">
<a href=""
ng-click="expandRow = !expandRow">
<i class="fa fa-caret-down"
ng-show="expandRow"></i>
<i class="fa fa-caret-right"
ng-hide="expandRow"></i>
</a>&nbsp;
<strong>
<a href="#!/story/{{story.id}}">
{{story.id}}
</a>
</strong>
</td>
<td>
<p>
<strong>
<a href="#!/story/{{story.id}}">
{{story.title}}
</a>
</strong>
<br/>
<small class="text-muted honor-carriage-return" ng-show="expandRow">
{{story.description}}
</small>
</p>
</td>
<td class="text-right">
<p class="label {{statusLabelStyle}}"
ng-click="expandRow = !expandRow">
<i class="fa fa-caret-down"
ng-show="expandRow"></i>
<i class="fa fa-caret-right"
ng-hide="expandRow"></i>
{{story.status | capitalize}}
</p>
<table ng-show="expandRow"
class="table table-clean table-supercondensed">
<tr>
<th>
<small>Todo:</small>
</th>
<td>
<strong>
<small>{{story.todo || 0}}</small>
</strong>
</td>
</tr>
<tr class="text-info">
<th>
<small>Progress:</small>
</th>
<td>
<strong>
<small>{{story.inprogress || 0}}</small>
</strong>
</td>
</tr>
<tr class="text-warning">
<th>
<small>Review:</small>
</th>
<td>
<strong>
<small>{{story.review || 0}}</small>
</strong>
</td>
</tr>
<tr class="text-success">
<th>
<small>Merged:</small>
</th>
<td>
<strong>
<small>{{story.merged || 0}}</small>
</strong>
</td>
</tr>
<tr class="text-muted">
<th>
<small>Invalid:</small>
</th>
<td>
<strong>
<small>{{story.invalid || 0}}</small>
</strong>
</td>
</tr>
</table>
</td>