911 Commits

Author SHA1 Message Date
Doug Hellmann
1044a1369f do not set OS_TEST_TIMEOUT in tox.ini
Do not set the variable in tox.ini, because that overrides any value
the user is trying to pass on the command line or from their
environment. A default is already set in .testr.conf using shell
syntax that supports using the value from the user if there is one.

Change-Id: I5ff1880655e927ea596217154958fb95857f5649
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-01-30 11:00:13 -05:00
Zuul
82b65ab421 Merge "Add documentation on manually upgrading a StoryBoard instance" 2018-01-19 04:02:32 +00:00
Doug Hellmann
520a3fd173 fix rst heading styles
Make the heading styles consistent and use different styles for the
page title and in-page headings so they are all displayed in the HTML
output.

Change-Id: I6685eea7c4840e60aa92316d7c42cb9c29932c2f
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-01-17 12:03:48 -05:00
Doug Hellmann
2a176d1d0c fix rst formatting
Fix some indentation and other markup issues in the RST for the
documentation.

Change-Id: I921445f7120335510ee7b203a2210737012bcdf2
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-01-12 16:38:41 -05:00
Doug Hellmann
708d09be77 update documentation build for new PTI
Move documentation dependencies to doc/requirements.txt

Change tox.ini to run sphinx-build directly, like the zuul job does.

Switch from oslosphinx to openstackdocstheme.

Change-Id: I079ff78edacaba673461824af770344cb3a896f2
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-01-12 16:24:59 -05:00
Zuul
72a62c7f0a Merge "Remove Update tox Step" 2018-01-10 20:30:20 +00:00
Zuul
108cfb19a0 Merge "Cleanup Migration Docs" 2018-01-10 20:10:28 +00:00
Zara
c0c3c0900b Pin version of webob to 1.7.4
Pecan depends on webob. We don't currently specify a version,
so Pecan pulls in the latest version of webob. (1.8.0rc1)
There is some incompatibility between our codebase and
the latest version of webob, causing our tests to fail.
This patch pins webob to the last known compatible version,
so that development is not blocked on investigating the
incompatibility.

In the future, we should investigate further so that we
can use up to date python dependencies

Change-Id: I8d4f14c992c18b53888657580a292a21b565de85
2018-01-05 21:45:52 +00:00
Kendall Nelson
3232daf011 Remove Update tox Step
Since the tox bug has been resolved[1] and tox has also moved past versions
1.6 and 1.7, this patch removes the caveat about using the correct version
of tox.

[1] https://bugs.launchpad.net/openstack-ci/+bug/1274135

Change-Id: Ib13c1380867c3ac93d04140801a40e9023c03943
2018-01-03 16:45:58 -08:00
Kendall Nelson
2cc988b4e1 Cleanup Migration Docs
Since the edit to the migration script to handle
multiple branches has merged, this patch removes the extra
steps in the test migration discussing multiple branches.

Change-Id: I8d6c78e9892f9f40c4c3b9b469f80e40a738eaac
2017-12-19 15:17:05 -08:00
Zuul
7eddc73f7e Merge "Bump minimum os-testr requirement to 1.0.0" 2017-11-06 10:03:53 +00:00
Zuul
a0243beae9 Merge "Consolidate old database migrations" 2017-10-25 00:28:23 +00:00
Zuul
b5898ddc8b Merge "Add Test Migration Directions" 2017-10-23 20:14:20 +00:00
Matthew Treinish
f7556744bb
Bump minimum os-testr requirement to 1.0.0
This commit bumps the os-testr version to use 1.0.0. 1.0.0 changes the
internals to use stestr instead of subprocessing testr. A bunch of
incorrect imports in the tests were updated as a well, relying on
relative import paths is finicky at the best of times so to make the
tests work this just points to the path based on the root of the package
instead.

Change-Id: I2aed3f6a9adeac2b7dbe58ee12c0a1485278d56f
2017-10-16 20:29:39 -04:00
Adam Coldrick
87ab62f396 Add documentation on manually upgrading a StoryBoard instance
Sometimes it is necessary to upgrade the database of a manually
deployed StoryBoard instance, for example when updating a test
server being used for development.

This commit adds some documentation on how the `storyboard-db-manage`
command-line tool can be used to upgrade and downgrade the
database.

Change-Id: I0ac21ddc3bacac7105efda7258e7ae52818f8f69
2017-10-11 22:06:45 +01:00
Adam Coldrick
d0b595db25 Consolidate old database migrations
This commit consolidates the migrations between 001 and 048 (inclusive)
into a single database migration, to speed up the process of creating a
new database.

Change-Id: I2718165fc246ad499e6c3b164f557e9ab1580c03
2017-10-09 19:58:29 +01:00
Jenkins
acce431b30 Merge "Check story permissions when populating automatic worklists" 2017-10-05 13:43:36 +00:00
Jenkins
7fa5ac5e08 Merge "Handle Branches from Launchpad in Migration" 2017-10-05 08:45:39 +00:00
Adam Coldrick
1080289891 Check story permissions when populating automatic worklists
Currently, when populating the items of an automatic worklist,
the permissions set on private stories is not taken into account.

This commit fixes this issue by filtering out stories and tasks
that the user shouldn't be able to see when finding the list
of stories and tasks which match the worklist's filters.

Change-Id: If37be62890db913b428af4e6a94ee21754c6ac56
2017-10-04 20:20:03 +01:00
Kendall Nelson
b20a30ec57 Add Test Migration Directions
This patch adds the directions for how to do a
test migration of a project.

Change-Id: I90948c7d4a220de16ddbe6c1d4b6ed72e05d7d17
2017-09-29 11:37:13 -07:00
Jenkins
9937096cfc Merge "Minimise database queries when populating automatic worklists" 2017-09-12 20:14:03 +00:00
Jenkins
42511bf954 Merge "Minimise database queries when resolving cards" 2017-09-12 19:32:02 +00:00
Zara
1cfb51aa65 Pin os-testr to version 0.8.2
This commit pins the os-testr version to 0.8.2, as more recent changes
to the backend mean that some storyboard modules are not found. In the
future, we should adjust storyboard to work with the more recent
os-testr version, either by changing paths to those modules or
by explicitly pointing to them.

Change-Id: Iad68613d294179548d4ca73d75df699b05e7d0d7
2017-09-12 11:54:21 -04:00
Kendall Nelson
c7315825f3 Handle Branches from Launchpad in Migration
When migrating bugs from launchpad to StoryBoard, there is only
logic in place for master branches. If a bug exists on a branch
other than master, its added to master anyway. This patch gets the
branch info from the bug, checks that the branch exists in the project
and if it doesn't advises on creating the branch and exits. Otherwise
the bug is created.

This patch also cleans up other pep8 errors related to print
statements.

Change-Id: I0c1c8d3ebef80fd0937eaa343fdb26f7aadec67c
2017-08-30 14:49:09 -07:00
Adam Coldrick
5588b5252a Minimise database queries when populating automatic worklists
When populating automatic worklists we currently throw away
queries representing the list of story and task objects to
appear in the worklist, and then later on reacquire this data
using one query per story or task.

This commit makes use of the ability to resolve stories and
tasks from a pre-loaded cache to reuse the queries constructed
when first populating the list to get the story data with no
additional database interaction.

This commit also makes the population of the task or story's
due dates optional, as this doesn't make sense for automatic
worklists (wherein due dates cannot be applied).

Change-Id: I76f29e9b9100693691187cffa64b3e6a02120ccb
2017-08-30 20:49:08 +01:00
Adam Coldrick
0c4f267433 Minimise database queries when resolving cards
This commit modifies the code which resolves the contents of cards
in boards and worklists such that instead of making a database
query per-card, two queries are made to obtain all tasks and stories
that there are cards for in the board/worklist.

The result of these queries is passed into the resolution function
in order to allow fast lookup of the underlying story/task for a card.

This will lead to much faster loading times for boards containing
large numbers of cards.

Change-Id: I189a1d9823a7d251af641cf24de52faac24584df
2017-08-30 20:49:08 +01:00
Jenkins
13fd2d0725 Merge "Adds Migration Documentation" 2017-08-30 19:17:21 +00:00
Kendall Nelson
e6de86b71f Adds Migration Documentation
This patch adds information about preparing to
migrate, the migration process, and things to do
after migrating.

Change-Id: Ia4b31172e28255575504804c3b451139938e6a97
2017-08-29 15:38:04 -07:00
Jenkins
d8316e0c45 Merge "Add a configurable fallback URL for emails" 2017-08-23 21:41:34 +00:00
Tristan Cacqueray
ca537c255a Better handle pika connection errors
It seems like pika may raise AttributeError when the connection is closed,
as describe here: https://github.com/pika/pika/issues/638, resulting
in this error displayed on the webclient:
500: POST /storyboard_api/tasks: 'NoneType' object has no attribute 'send'

This change adds AttributeError to the ConnectionClosed except.

Change-Id: Iffa1ef1998379097b32d699a360b5de9277c01ed
2017-07-11 03:05:22 +00:00
Jenkins
197fdd795f Merge "Set wsme decorator return type to None for some delete calls" 2017-06-28 20:58:07 +00:00
Jenkins
bf30de7a99 Merge "Allow stories and tasks to be filtered by boards/worklists containing them" 2017-05-31 23:23:31 +00:00
Fabien Boucher
6398006749 Set wsme decorator return type to None for some delete calls
This patch fixes Storyboard returning a body along with
a DELETE response 204 No Content for some endpoints.

Change-Id: I3d21e98d5cd737b652f001c403c827e9d2a0c197
Co-Authored-By: Matthieu Huin <mhuin@redhat.com>
2017-05-10 18:11:16 +02:00
Adam Coldrick
1e9d3d707f Add a configurable fallback URL for emails
This will allow the fixing of an issue where changes created
by things using the API directly, such as the Gerrit plugin,
cause broken URLs in notification emails.

Change-Id: Ibad10fa35b7acaaa59cbb28b0960571480f80552
2017-04-06 19:31:31 +01:00
Adam Coldrick
886b9dcc0b Allow stories and tasks to be filtered by boards/worklists containing them
Currently this is only supported for the internal database API surface,
with the intention of using it to reduce the amount of work done by the
boards and worklists APIs.

This patch also names some aliases we create to make debugging less
painful.

It also modifies the join to the StorySummary query such that the
column name is no longer hardcoded. This handles the case when we
have filtered out private worklists from the result (when joining
to worklists), which results in an anonymous column name we cannot
hardcode.

Change-Id: I3aaa874ae623a44edd668471794f8146c6dabda7
2017-04-06 13:08:54 +01:00
Fabien Boucher
6c56506bc5 Decrease projects and project_groups name MIN length limitation
This patch changes the MIN length limitation. The validation check
changes from 5 to 3 min characters.

Change-Id: Ib207d68e9f28e0fe8ef4a0a50897a69eed6f3118
2017-04-03 08:52:25 +00:00
Fabien Boucher
90712c28ae Increase project and project group name length limitation
This patch increase it to 100 chars instead of 50.

Change-Id: I0613c0f15a3d8807627676c3392ed29ca6a24685
2017-04-03 08:47:37 +00:00
Adam Coldrick
1297093792 Add a UUID to the temporary email address
This fixes a bug where two users from Launchpad could
end up with the same temporary email address in StoryBoard,
if they both have the same name. This would cause the
migration of projects to fail since we require email
addresses to be unique.

Change-Id: I7f8a75b9702d81f336cfcd6881ac2d6614ee992c
2017-03-11 16:17:25 +00:00
Jenkins
d2ca0f0395 Merge "Add imported tasks to master branch of relevant project" 2017-03-08 19:47:41 +00:00
Adam Coldrick
19b4ef8b0f Add imported tasks to master branch of relevant project
Change-Id: I65027746331e2ed44aecc4c8333825a00c4b9237
2017-03-03 00:56:52 +00:00
Luigi Toscano
146ab70a56 Use ostestr instead of the custom pretty_tox.sh
Switch to os-testr as wrapper for testr, instead of the custom
script pretty_tox.sh.

Change-Id: I5b76cf9ffca530664b1c1ddcbf98679ab4fca8b5
2017-02-09 12:29:41 +01:00
Jenkins
496e6f868a Merge "Prepare for using standard python tests" 2017-02-07 12:40:44 +00:00
Andreas Jaeger
d900740366 Prepare for using standard python tests
Add simple script to setup mysql and postgresql databases,
this script can be run by users during testing and will be
run by CI systems for specific setup before running unit tests.

This allows us to change in project-config the python-db jobs to
python-jobs since python-jobs will call this script initially.

Update documentation for this.

See also http://lists.openstack.org/pipermail/openstack-dev/2016-November/107784.html

Needed-By: I4566705d6e8ff17b2d400111919f6e1a0d0db3eb
Change-Id: I56fbce9fe0d0c90734f28457886b7a27bf8479f4
2017-02-02 12:12:46 +00:00
Jenkins
bbbf5eb249 Merge "Remove contentless operator manual" 2017-02-01 19:38:58 +00:00
Jenkins
0f3948c7c0 Merge "Support MariaDB in the migration scripts" 2017-01-31 15:33:08 +00:00
Tristan Cacqueray
68df79f5ea Support MariaDB in the migration scripts
When using mysql+pymysql in the connection uri, the server_version_info
tupple is (5, 5, 5, 10, 1, 18, u'MariaDB'), which makes the version check
incorrectly prevent using FULLTEXT index.

Using the last four elements from the tupple seems good enough to
mitigate this inconsistency.

Change-Id: I5db3b611535e197699ea5d331f7bd073a39a31c4
2017-01-31 05:32:43 +00:00
Jenkins
a7bbc0575f Merge "Improve webclient install instructions" 2017-01-18 19:29:01 +00:00
Jenkins
97b0a8d420 Merge "Fix install guide MySQL admin instructions" 2017-01-18 19:16:55 +00:00
Jenkins
0022dbd437 Merge "Remove link to modindex" 2017-01-11 19:31:08 +00:00
Zara
d734dc0c29 Remove contentless operator manual
We want a quickstart-for-operators guide, but the existing one is full
of placeholder content and is more confusing than helpful, as it
directs readers to a link which is a dead-end. Remove it.

Change-Id: Icd1068008511f2d9c00a3eec7b3969dc5024ee25
2017-01-09 21:31:12 +00:00