From 7f4a2ef50fc477769c0fef7e42d78568e5a4d25b Mon Sep 17 00:00:00 2001
From: Clark Boylan <clark.boylan@gmail.com>
Date: Fri, 6 Dec 2024 10:14:08 -0800
Subject: [PATCH] Remove log cleanup cronjob from review
Gerrit should be cleaning up logfiles on its own now. That means we
don't need a cronjob to do it. This is step 1 of a two step process
where we first have ansible remove the cronjob then step 2 will remove
the cronjob from ansible entirely.
Change-Id: I82825de65c28cea43e9a472884b880d6f01efabe
---
playbooks/roles/gerrit/tasks/main.yaml | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/playbooks/roles/gerrit/tasks/main.yaml b/playbooks/roles/gerrit/tasks/main.yaml
index db7a8c400b..41b91b4fa2 100644
--- a/playbooks/roles/gerrit/tasks/main.yaml
+++ b/playbooks/roles/gerrit/tasks/main.yaml
@@ -347,14 +347,12 @@
minute: 17
hour: 4
-# Gerrit rotates their own logs, but doesn't clean them out
-# Delete logs older than a month
-# TODO set state to absent then remove entirely after we upgrade to
-# Gerrit 3.10 and set log.timeToKeep to do this rotation natively.
+# Gerrit rotates logs on its own now. Clean up our old cron job that did it
+# before.
- name: Set up cron job to clean old gerrit logs
cron:
name: clear-gerrit-logs
- state: present
+ state: absent
user: gerrit2
job: 'find /home/gerrit2/review_site/logs/*.gz -mtime +30 -exec rm -f {} \;'
minute: 1