From b2573d3d33b766156fd90f3d16ab4a988c8dc899 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Thu, 27 Dec 2012 16:58:03 -0800 Subject: [PATCH] Cleanup puppet parser warnings. Cleanup warnings for missing '$' in class parameter definitions and for non upper cased requirements. Change-Id: I5fe04a304b084f4c6d09cfb23a9dfae2548a8e22 Reviewed-on: https://review.openstack.org/18704 Reviewed-by: James E. Blair Reviewed-by: Paul Belanger Approved: Jeremy Stanley Reviewed-by: Jeremy Stanley Tested-by: Jenkins --- modules/etherpad_lite/manifests/buildsource.pp | 4 ++-- modules/openstack_project/manifests/pypi_slave.pp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/etherpad_lite/manifests/buildsource.pp b/modules/etherpad_lite/manifests/buildsource.pp index b0ce035431..a2ebbd056b 100644 --- a/modules/etherpad_lite/manifests/buildsource.pp +++ b/modules/etherpad_lite/manifests/buildsource.pp @@ -15,7 +15,7 @@ define etherpad_lite::buildsource( user => $user, cwd => $dir, creates => $creates, - before => exec["make in ${dir}"], + before => Exec["make in ${dir}"], } exec { "make in ${dir}": @@ -25,7 +25,7 @@ define etherpad_lite::buildsource( cwd => $dir, timeout => $timeout, creates => $creates, - before => exec["make install in ${dir}"], + before => Exec["make install in ${dir}"], } exec { "make install in ${dir}": diff --git a/modules/openstack_project/manifests/pypi_slave.pp b/modules/openstack_project/manifests/pypi_slave.pp index 904514da8e..5178641b9c 100644 --- a/modules/openstack_project/manifests/pypi_slave.pp +++ b/modules/openstack_project/manifests/pypi_slave.pp @@ -15,8 +15,8 @@ # Class to install dependencies for uploading python packages to pypi. # class openstack_project::pypi_slave ( - pypi_password, - pypi_username = 'openstackci' + $pypi_password, + $pypi_username = 'openstackci' ) { include openstack_project::slave include pip