opendev/system-config
Code Issues Proposed changes

Cleanup snmpd manifest init.pp lint errors.

Browse Source 
Change-Id: I970c492c11d91dfab3b206859a72598a16602a24
Reviewed-on: https://review.openstack.org/14906
Reviewed-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
This commit is contained in:
Matthew Wagoner 2012-10-26 14:36:46 -04:00 committed by Jenkins
parent 234804ed84
commit d9ca4564ec
1 changed files with 34 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
modules/snmpd/manifests/init.pp
View File

@ -1,30 +1,36 @@
# == Class: snmpd
#
class snmpd { class snmpd {
package { snmpd: ensure => present } package { 'snmpd':
service { snmpd: ensure => present,
ensure => running, }
hasrestart => true, service { 'snmpd':
require => [File["/etc/snmp/snmpd.conf"], ensure => running,
File["/etc/init.d/snmpd"]] hasrestart => true,
} require => [
# This file is only needed on machines pre-precise. There is a bug in File['/etc/snmp/snmpd.conf'],
# the previous init script versions which causes them to attempt File['/etc/init.d/snmpd'],
# snmptrapd even if it's configured not to run, and then to report ],
# failure. }
file { "/etc/init.d/snmpd": # This file is only needed on machines pre-precise. There is a bug in
owner => 'root', # the previous init script versions which causes them to attempt
group => 'root', # snmptrapd even if it's configured not to run, and then to report
mode => 755, # failure.
ensure => 'present', file { '/etc/init.d/snmpd':
source => 'puppet:///modules/snmpd/snmpd.init', ensure => present,
replace => 'true', owner => 'root',
require => Package[snmpd] group => 'root',
} mode => '0755',
file { "/etc/snmp/snmpd.conf": source => 'puppet:///modules/snmpd/snmpd.init',
owner => 'root', replace => true,
group => 'root', require => Package['snmpd'],
mode => 444, }
ensure => 'present', file { '/etc/snmp/snmpd.conf':
source => 'puppet:///modules/snmpd/snmpd.conf', ensure => present,
replace => 'true', owner => 'root',
} group => 'root',
mode => '0444',
source => 'puppet:///modules/snmpd/snmpd.conf',
replace => true,
}
} }