openinfra/python-tempestconf
Code Issues Proposed changes

Fix username is not defined warning

Browse Source 
The tool tries to find the credentials in auth section first
and if it gets None, it tries identity section then. Because
of this a unnecessary warning message is logged out.
The patch changes the way, how the credentials are retrieved
from conf, so that there are no warnings.

Change-Id: I841241bddeb12cac9207c15e9dc4e1de8860791b
Story: 2002539
Task: 22085
This commit is contained in:
Martin Kopec 2018-06-13 19:08:02 +00:00
parent b8f5b25728
commit 6d7968bb16
2 changed files with 7 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
config_tempest/credentials.py
View File

@ -53,24 +53,14 @@ class Credentials(object):
:returns: credential :returns: credential
:rtype: string :rtype: string
""" """
admin_prefix = 'admin_' if self.admin else "" if self.admin:
return self.get_identity_credential(admin_prefix + key) # admin credentials are stored in auth section
# and are prefixed by 'admin_'
def get_identity_credential(self, key): return self._conf.get_defaulted('auth', 'admin_' + key)
"""Get credential requested by its name. else:
# Tempest doesn't have non admin credentials, but the
The function is providing the backwards compatibility for looking up # tool keeps them in identity section for further usage
the credentials, because admin credentials were moved from identity
to auth section.
:param key: name of the credential e.g. username, passsword ...
:type key: string
:returns: credential
:rtype: string
"""
value = self._conf.get_defaulted('auth', key)
if value is None:
return self._conf.get_defaulted('identity', key) return self._conf.get_defaulted('identity', key)
return value
def _get_identity_version(self): def _get_identity_version(self):
"""Looks for identity version in TempestConf object. """Looks for identity version in TempestConf object.

12
config_tempest/tests/test_credentials.py
View File

@ -38,18 +38,6 @@ class TestCredentials(BaseConfigTempestTest):
resp = self.creds.get_credential("username") resp = self.creds.get_credential("username")
self.assertEqual(resp, "admin") self.assertEqual(resp, "admin")
def test_get_identity_credential(self):
for i in range(0, 2):
resp = self.creds.get_identity_credential("username")
self.assertEqual(resp, "demo")
# set admin credentials
self.creds.admin = True
resp = self.creds.get_identity_credential("admin_username")
self.assertEqual(resp, "admin")
# use conf which contains the newer values - (admin creds
# in auth section)
self.creds._conf = self._get_alt_conf("v2.0", "v3")
def test_get_identity_version_v2(self): def test_get_identity_version_v2(self):
resp = self.creds._get_identity_version() resp = self.creds._get_identity_version()
self.assertEqual(resp, 'v2') self.assertEqual(resp, 'v2')