openstack/ansible-collections-openstack
Code Issues Proposed changes

Router: Remove unneeded 'filter' parameter

Browse Source 
Change-Id: If46916e3480fced3be919c6d39b82a6c64321065
This commit is contained in:
Jan Weiher 2022-03-09 14:53:54 +01:00
parent 9d0e5dd1db
commit ea2ee76a88
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/modules/router.py
View File

@ -234,8 +234,7 @@ class RouterModule(OpenStackModule):
missing_port_ids, missing_port_ids,
requested_subnet_ids, requested_subnet_ids,
existing_subnet_ids, existing_subnet_ids,
router_ifs_cfg, router_ifs_cfg):
filters=None):
"""Decide if the given router needs an update.""" """Decide if the given router needs an update."""
if router['admin_state_up'] != self.params['admin_state_up']: if router['admin_state_up'] != self.params['admin_state_up']:
return True return True
@ -476,8 +475,7 @@ class RouterModule(OpenStackModule):
missing_port_ids, missing_port_ids,
requested_subnet_ids, requested_subnet_ids,
existing_subnet_ids, existing_subnet_ids,
router_ifs_cfg, router_ifs_cfg)
filters)
self.exit_json(changed=changed) self.exit_json(changed=changed)
if state == 'present': if state == 'present':
@ -510,8 +508,7 @@ class RouterModule(OpenStackModule):
missing_port_ids, missing_port_ids,
requested_subnet_ids, requested_subnet_ids,
existing_subnet_ids, existing_subnet_ids,
router_ifs_cfg, router_ifs_cfg):
filters):
changed = True changed = True
kwargs = self._build_kwargs(router, net) kwargs = self._build_kwargs(router, net)
updated_router = self.conn.update_router(**kwargs) updated_router = self.conn.update_router(**kwargs)