Skip sysctl configs when enabled: no
The intended functionality for "enabled: no" on sysctl configurations was to skip the config entirely and leave the variable unaltered. However, setting "enabled: no" was causing the configuration to be removed entirely. This patch ensures that any sysctl variables with "enabled: no" are skipped and left unaltered. Closes-Bug: 1710490 Depends-On: I2607f295a924a2ec51920b5f2b27c34d5222e8ff Change-Id: If9c8c008538b2ff631a714a8ffe16df9376dedf3
This commit is contained in:
parent
ca9b2e2cb7
commit
f576f24591
@ -0,0 +1,10 @@
|
|||||||
|
---
|
||||||
|
fixes:
|
||||||
|
- |
|
||||||
|
The sysctl configuration task was not skipping configurations where
|
||||||
|
``enabled`` was set to ``no``. Instead, it was removing configurations
|
||||||
|
when ``enabled: no`` was set.
|
||||||
|
|
||||||
|
There is now a fix in place that ensures any sysctl configuration with
|
||||||
|
``enabled: no`` will be skipped and the configuration will be left
|
||||||
|
unaltered on the system.
|
@ -31,6 +31,8 @@
|
|||||||
value: "{{ item.value }}"
|
value: "{{ item.value }}"
|
||||||
state: "{{ item.enabled | ternary('present', 'absent') }}"
|
state: "{{ item.enabled | ternary('present', 'absent') }}"
|
||||||
reload: yes
|
reload: yes
|
||||||
|
when:
|
||||||
|
- item.enabled | bool
|
||||||
with_items: "{{ sysctl_settings_rhel7 }}"
|
with_items: "{{ sysctl_settings_rhel7 }}"
|
||||||
tags:
|
tags:
|
||||||
- medium
|
- medium
|
||||||
|
@ -317,7 +317,9 @@ shadow_utils_rhel7:
|
|||||||
#
|
#
|
||||||
# name: the sysctl configuration name
|
# name: the sysctl configuration name
|
||||||
# value: the value to set for the sysctl configuration
|
# value: the value to set for the sysctl configuration
|
||||||
# enabled: whether the variable should be set or not
|
# enabled: yes or no
|
||||||
|
# - 'yes' (ensure the variable is set)
|
||||||
|
# - 'no' (the role will not alter the configuration)
|
||||||
#
|
#
|
||||||
sysctl_settings_rhel7:
|
sysctl_settings_rhel7:
|
||||||
- name: net.ipv4.conf.all.accept_source_route
|
- name: net.ipv4.conf.all.accept_source_route
|
||||||
|
Loading…
x
Reference in New Issue
Block a user