openstack/ironic
Code Issues Proposed changes

Enforce autospec in test_cinder

Browse Source 
And remove corresponding filter from tox.ini

Change-Id: Ia8f608fbf2c6feffcf23da84ae91ccf3d6ea4baa
This commit is contained in:
Riccardo Pittau 2020-08-06 18:17:50 +02:00
parent 09c10ef92b
commit 15fa7ac816
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ironic/tests/unit/drivers/modules/storage/test_cinder.py
View File

@ -368,7 +368,7 @@ class CinderInterfaceTestCase(db_base.DbTestCase):
@mock.patch.object(cinder_common, 'detach_volumes', autospec=True)
@mock.patch.object(cinder_common, 'attach_volumes', autospec=True)
@mock.patch.object(cinder, 'LOG')
@mock.patch.object(cinder, 'LOG', autospec=True)
def test_attach_detach_volumes_no_volumes(self, mock_log,
mock_attach, mock_detach):
with task_manager.acquire(self.context, self.node.id) as task:
@ -400,7 +400,8 @@ class CinderInterfaceTestCase(db_base.DbTestCase):
@mock.patch.object(cinder_common, 'detach_volumes', autospec=True)
@mock.patch.object(cinder_common, 'attach_volumes', autospec=True)
@mock.patch.object(cinder, 'LOG', autospec=True)
@mock.patch.object(objects.volume_target.VolumeTarget, 'list_by_volume_id')
@mock.patch.object(objects.volume_target.VolumeTarget, 'list_by_volume_id',
autospec=True)
def test_attach_detach_called_with_target_and_connector(self,
mock_target_list,
mock_log,
@ -514,7 +515,7 @@ class CinderInterfaceTestCase(db_base.DbTestCase):
self.assertEqual(1, mock_log.warning.call_count)
@mock.patch.object(cinder_common, 'detach_volumes', autospec=True)
@mock.patch.object(cinder, 'LOG')
@mock.patch.object(cinder, 'LOG', autospec=True)
def test_detach_volumes_failure_raises_exception(self,
mock_log,
mock_detach):

1
tox.ini
View File

@ -136,7 +136,6 @@ per-file-ignores =
ironic/tests/unit/drivers/modules/ilo/*:H210
ironic/tests/unit/drivers/modules/irmc/*:H210
ironic/tests/unit/drivers/modules/xclarity/*:H210
ironic/tests/unit/drivers/modules/storage/*:H210
[hacking]
import_exceptions = testtools.matchers, ironic.common.i18n