From 697eb010248fe5e19cfe676a7d714051b3d121e8 Mon Sep 17 00:00:00 2001 From: Riccardo Pittau Date: Fri, 5 Jun 2020 18:50:49 +0200 Subject: [PATCH] Enforce autospec in test_snmp And remove corresponding H210 filters. Change-Id: I376b2f06bce774ecf57a259acfea12e394069cef --- ironic/tests/unit/drivers/modules/test_snmp.py | 11 ++++++----- tox.ini | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ironic/tests/unit/drivers/modules/test_snmp.py b/ironic/tests/unit/drivers/modules/test_snmp.py index 3272934d18..ba6fd6bc4a 100644 --- a/ironic/tests/unit/drivers/modules/test_snmp.py +++ b/ironic/tests/unit/drivers/modules/test_snmp.py @@ -1603,7 +1603,8 @@ class SNMPDeviceDriverTestCase(db_base.DbTestCase): mock_client.get.assert_called_once_with(SNMPDriverAuto.SYS_OBJ_OID) - @mock.patch.object(snmp.SNMPDriverAPCRackPDU, "_snmp_power_on") + @mock.patch.object(snmp.SNMPDriverAPCRackPDU, "_snmp_power_on", + autospec=True) def test_snmp_auto_cache_supports_pdu_replacement( self, broken_pdu_power_on_mock, mock_get_client): @@ -1695,7 +1696,7 @@ class SNMPDriverTestCase(db_base.DbTestCase): task.driver.power.get_power_state, task) mock_driver.power_state.assert_called_once_with() - @mock.patch.object(snmp.LOG, 'warning') + @mock.patch.object(snmp.LOG, 'warning', autospec=True) def test_set_power_state_on(self, mock_log, mock_get_driver): mock_driver = mock_get_driver.return_value mock_driver.power_on.return_value = states.POWER_ON @@ -1704,7 +1705,7 @@ class SNMPDriverTestCase(db_base.DbTestCase): mock_driver.power_on.assert_called_once_with() self.assertFalse(mock_log.called) - @mock.patch.object(snmp.LOG, 'warning') + @mock.patch.object(snmp.LOG, 'warning', autospec=True) def test_set_power_state_on_timeout(self, mock_log, mock_get_driver): mock_driver = mock_get_driver.return_value mock_driver.power_on.return_value = states.POWER_ON @@ -1763,7 +1764,7 @@ class SNMPDriverTestCase(db_base.DbTestCase): task, states.POWER_OFF) mock_driver.power_off.assert_called_once_with() - @mock.patch.object(snmp.LOG, 'warning') + @mock.patch.object(snmp.LOG, 'warning', autospec=True) def test_reboot(self, mock_log, mock_get_driver): mock_driver = mock_get_driver.return_value mock_driver.power_reset.return_value = states.POWER_ON @@ -1772,7 +1773,7 @@ class SNMPDriverTestCase(db_base.DbTestCase): mock_driver.power_reset.assert_called_once_with() self.assertFalse(mock_log.called) - @mock.patch.object(snmp.LOG, 'warning') + @mock.patch.object(snmp.LOG, 'warning', autospec=True) def test_reboot_timeout(self, mock_log, mock_get_driver): mock_driver = mock_get_driver.return_value mock_driver.power_reset.return_value = states.POWER_ON diff --git a/tox.ini b/tox.ini index d45bbb6037..1ccc6737ed 100644 --- a/tox.ini +++ b/tox.ini @@ -135,7 +135,6 @@ per-file-ignores = ironic/tests/unit/common/*:H210 ironic/tests/unit/drivers/modules/test_console_utils.py:H210 ironic/tests/unit/drivers/modules/test_iscsi_deploy.py:H210 - ironic/tests/unit/drivers/modules/test_snmp.py:H210 ironic/tests/unit/drivers/modules/network/*:H210 ironic/tests/unit/drivers/modules/ilo/*:H210 ironic/tests/unit/drivers/modules/irmc/*:H210