openstack/ironic
Code Issues Proposed changes

Do not silence the actual error in prepare_instance_boot

Browse Source 
This call can fail for a lot of very different reasons (e.g. right now
I'm looking at secure boot operations getting HTTP 403 from iLO 6, but
it could just as well be something coming from IPA).

Change-Id: I4a884e3ccc0e1bf12aa9287cf521e1295f8a2476
This commit is contained in:
Dmitry Tantsur 2025-03-28 15:49:22 +01:00
parent f25b095825
commit b43d74a8f4
No known key found for this signature in database
GPG Key ID: 315B2AF9FD216C60
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ironic/drivers/modules/agent.py
View File

@ -435,7 +435,7 @@ class CustomAgentDeploy(agent_base.AgentBaseMixin,
'%(node)s. %(cls)s: %(error)s',
{'node': task.node.uuid,
'cls': e.__class__.__name__, 'error': e})
msg = _('Failed to prepare instance for booting')
msg = _('Failed to prepare instance for booting: %s') % e
agent_base.log_and_raise_deployment_error(task, msg, exc=e)
@METRICS.timer('CustomAgentDeploy.tear_down_agent')
@ -861,7 +861,7 @@ class AgentDeploy(CustomAgentDeploy):
'%(instance)s. %(cls)s: %(error)s',
{'instance': node.instance_uuid,
'cls': e.__class__.__name__, 'error': e})
msg = _('Failed to prepare instance for booting')
msg = _('Failed to prepare instance for booting: %s') % e
agent_base.log_and_raise_deployment_error(task, msg, exc=e)
@METRICS.timer('AgentDeploy.configure_local_boot')