From b43d74a8f4b4f3a24b6c5f7edaa905dab3436acc Mon Sep 17 00:00:00 2001 From: Dmitry Tantsur Date: Fri, 28 Mar 2025 15:49:22 +0100 Subject: [PATCH] Do not silence the actual error in prepare_instance_boot This call can fail for a lot of very different reasons (e.g. right now I'm looking at secure boot operations getting HTTP 403 from iLO 6, but it could just as well be something coming from IPA). Change-Id: I4a884e3ccc0e1bf12aa9287cf521e1295f8a2476 --- ironic/drivers/modules/agent.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ironic/drivers/modules/agent.py b/ironic/drivers/modules/agent.py index 39f25bbe84..6c93abebfc 100644 --- a/ironic/drivers/modules/agent.py +++ b/ironic/drivers/modules/agent.py @@ -435,7 +435,7 @@ class CustomAgentDeploy(agent_base.AgentBaseMixin, '%(node)s. %(cls)s: %(error)s', {'node': task.node.uuid, 'cls': e.__class__.__name__, 'error': e}) - msg = _('Failed to prepare instance for booting') + msg = _('Failed to prepare instance for booting: %s') % e agent_base.log_and_raise_deployment_error(task, msg, exc=e) @METRICS.timer('CustomAgentDeploy.tear_down_agent') @@ -861,7 +861,7 @@ class AgentDeploy(CustomAgentDeploy): '%(instance)s. %(cls)s: %(error)s', {'instance': node.instance_uuid, 'cls': e.__class__.__name__, 'error': e}) - msg = _('Failed to prepare instance for booting') + msg = _('Failed to prepare instance for booting: %s') % e agent_base.log_and_raise_deployment_error(task, msg, exc=e) @METRICS.timer('AgentDeploy.configure_local_boot')