redfish: permit ipmitool-socat console for redfish usage

We've had a couple asks about enabling ipmitool-socat console usage
with the redfish hardware type.

This doesn't pickup parameters from driver_info to figure out the IPMI
username, password, and hostname/address, which turns out to be a rather
invasive change to ipmi handling code and test code as well.

Change-Id: I69dfeeec59317871c9f6a206966dd6a9d2ca9e3e

doc/source/admin/console.rst

@@ -213,7 +213,12 @@ Node serial console
 -------------------
 
 Serial consoles for nodes are implemented using `socat`_. It is supported by
-the ``ipmi`` and ``irmc`` hardware types.
+the ``ipmi``, ``irmc``, and ``redfish`` hardware types.
+
+.. NOTE::
+   The use of the ``ipmitool-socat`` console interface on any hardware type
+   requires the ipmi connection parameters to be set into the ``driver_info``
+   filed on the node.
 
 Serial consoles can be configured in the Bare Metal service as follows:
 

ironic/drivers/redfish.py

@@ -15,6 +15,7 @@
 
 from ironic.drivers import generic
 from ironic.drivers.modules import agent
+from ironic.drivers.modules import ipmitool
 from ironic.drivers.modules import noop
 from ironic.drivers.modules import noop_mgmt
 from ironic.drivers.modules.redfish import bios as redfish_bios
@@ -78,4 +79,6 @@ class RedfishHardware(generic.GenericHardware):
     @property
     def supported_console_interfaces(self):
         """List of supported console interfaces."""
-        return [graphical_console.RedfishGraphicalConsole, noop.NoConsole]
+        return [graphical_console.RedfishGraphicalConsole,
+                ipmitool.IPMISocatConsole,
+                noop.NoConsole]

releasenotes/notes/redfish-permit-ipmi-socat-console-9ede51ab0bc9f17d.yaml

@@ -0,0 +1,8 @@
+---
+features:
+  - |
+    The ``ipmitool-socat`` console interface is now available for users of the
+    ``redfish`` hardware type. This was done as an enablement action for
+    operators to be able to leverage IPMI based Serial-over-Lan connections.
+    This option requires the IPMI parameters to be configured on the baremetal
+    node in addition to the ``redfish`` hardware type.