The deploy_is_done() method from the AgentClient is very implementation
specific, so this patch is moving it into the AgentVendorInterface class
for the agent driver.
Change-Id: I92cdac24d5225ecfcb858bacdd672c3f8c0efed2
This patch is moving the common pieces of the AgentVendorInterface to
a common place and into a new class called BaseAgentVendor which can
be overwritten and used by other drivers using IPA as their deployment
ramdisk.
The tests were also splitted and a new test_deploy_is_done() have been
added to the AgentVendorInterface test case.
This patch is a forklift, when IPA becomes the default ramdisk for
all drivers we might want to promote many of it's methods (e.g lookup,
heartbeat, ...) to the BaseVendor class.
Change-Id: I1e8af0c9a5f68e60f81a408defdbdf8c4d813d4e
Previously, when node was deleted with console enabled,
the console process was not stopped.
Now stop console at first, then delete the node.
Closes-Bug: #1418804
Change-Id: Ia994b20c42df0a1f2882889a1be6dd4f426ee569
Everything that is tracked in Ironic is done via UUID. This isn't very
friendly to humans.
This change adds a new concept to ironic, that being the <logical name>,
which can be used interchangeably with the <node uuid>. Everywhere a
<node uuid> can be specified, we are able to instead specify a <logical
name>, if such an association exists for that node.
APIImpact:
This raises the X-OpenStack-Ironic-API-Version to 1.5, and
adds a new "name" property to nodes, which can be substituted
for the UUID in requests.
This also adds a 'node' parameter for 'GET /v1/nodes/validate'. This
parameter can be a node's UUID or name. The existing 'node_uuid'
parameter is still supported.
DocImpact
blueprint: logical-names
Co-Authored-By: Devananda van der Veen <devananda.vdv@gmail.com>
Change-Id: I505181a1df064194848e3d5b79d01746024ce037
This patch implements the part that reads the specified boot_option in
the node.instance_info['capabilities'] that have been passed to Ironic by
the Nova Ironic Driver and pass that information to the deploy ramdisk
by adding it to the kernel cmdline in the PXE configuration file that
will be generated to that node.
This patch also makes sure that we clean the PXE configuration files for
the node marked to local boot after it's deployed, so that any attempt
to boot it from the network will not work.
This patch only apply to the pxe_* drivers, because the blueprint is
about adding local boot support for deployments that uses partition
images. The agent driver right now supports full disk images only.
Implements: blueprint local-boot-support-with-partition-images
Change-Id: Ide08e2b41dcf74c69dfbce242112da701fa15187
The chown command '-p' is invalid as below:
stack@ubuntu:~$ sudo chown -R ironic -p /tftpboot
chown: invalid option -- 'p'
Try 'chown --help' for more information.
The '-p' must be a typo of '-P'. But the manual says
'-P' option is default. So '-p' has been removed.
-P do not traverse any symbolic links (default)
Change-Id: Ic012a6a991645a128389367f07c9709366a09822
ironic.drivers.modules.ipmitool gives "Failed to create the password file.
expected a character buffer object" WARNING message and it causes "Error:
IPMI call failed: power status..". "expected a character buffer object" is
a python error message and raised when write() function expected string as
input type but gets something else (i.e. int / numeric) if ipmi password
is set just using numbers(i.e 12345678)
This simple bug fix solves the issue by casting "password" to string.
Change-Id: Id9645e06eb707ef21a7cb99c420309f54a95aa9b
Closes-Bug: 1416298
Currently the subnet creation step is not documented
in the baremetal installation guide. This is a necessary
step and should be included
Change-Id: I20e5ecd982ae724d653a2bdf89ea86527df57dff
Closes-bug: #1418659
This patch improves the iSCSI connection verification by polling
/dev/disk/by-path for the iSCSI connection. This should ensure that
the iSCSI block device is seen by the file system after login.
It also removes the hard coded sleep in the login method.
Change-Id: Ibf6b6a15471a6130f33788b8c3f26d4577bf79a3
Closes-bug: #1417307
The min and max attributes from the base.Version class is not needed,
it was set and used before when checking versions but right now we only
use the major and minor attributes.
Change-Id: Ic501db26a00c96ca55eb8fbcfc7b318599a48158
Add a list of python packages which are loaded by hardware drivers
but not included in global-requirements.
Change-Id: Iff8dc91e3cae0d8ecf26d5afbd0c60b673c16521
Ironic API already enforces admin role to run node-show. So a new
policy show_password is added to control if plain text passwords
in driver_info should be masked or not before sending back to
API calls. The default is masking password for all cases.
Change-Id: Icd3e6be049376bf7b4468f0c149a72a06643da32
Closes-Bug: #1406191
The conductor service should fail during startup if a configured driver,
eg. one that is specified in "enabled_drivers", is not found. At the
moment, it merely ignores missing drivers.
In addition to adding a check that all configured drivers are loaded,
this patch re-arranges some of the initialization of ConductorManager
such that an exception during init_host() does not result in
secondary exceptions being logged and obfuscating the cause, namely,
that no drivers were loaded.
Closes-bug: #1417954
Change-Id: I6a96f4b49891c92859479656fe36d2bbd38fe602
This patch adds the MANAGEABLE state, and associated transitions to and
from AVAILABLE, as well as a new RPC method to initiate transitions
between provisioning states.
It also adds a new VERBS entity to ironic/common/states.py to hold the
action-phrases, as described in blueprint new-ironic-state-machine. This
provides a single place to check whether a requested target state is
allowed to be requested by checking if the value is "in" the keys of
this dictionary. It also provides a mapping for two phrases which are
currently inconsistent:
target:deleted -> action:delete
target:active -> action:deploy
It updates the API controller for nodes.py without changing the HTTP
status codes which are returned in exception cases. The changes in unit
tests now prepare the node appropriately, but do not change the
assertions being tested.
Juno allowed the rebuild of a failed deploy to be initiated by PUTting
a target state of "active"; this behavior, while inconsistent with the
new state machine, is added to the state model for compatibility, now
that stronger checking is done within the API service, based on the
actual modelling of state transitions.
Implements: blueprint new-ironic-state-machine
Co-Authored-By: David Shrewsbury <shrewsbury.dave@gmail.com>
Change-Id: Id0af5a607b7432d287eef643c1e30e324dc4f879
When we added microversion support to the API, the initial and minimum
version was set to 1.0. However, there were five previous API changes
since the Juno release which are not discoverable through the API
versioning scheme.
The 1.0 tag should actually indicate "Juno stable API". This patch
advances the minimum API version to 1.1, retroactively changing the
versions applied by two prior features:
* 1.1 -> 1.2 Rename NOSTATE to Available
* 1.2 -> 1.3 Add Node.driver_internal_info
Also, the default version applied (when no
X-OpenStack-Ironic-API-Version header is supplied) is raised to 1.1. A
client request that does not specify the header will retain the same
behavior as before this patch -- namely, the behavior prior to commit
I34bf7fa1b21580337c18206798dd8e9dfe11ba09. A client request which
specifies a version of 1.0 will result in an HTTP 406 Unsupported error
code today.
This patch leaves open the possibility for retroactively adding support
for the Juno API in future patches during the Kilo cycles, if necessary.
Change-Id: I7bc10ce72a461b8b68f5e07e1f27ec053f72a41a
The work_on_disk() function is defined with 7 normal arguments
and 2 optional arguments. The 'node_uuid' should be a string
containing uuid for the node, mainly for logging purposes.
However, there are several places in the unit test where the 7th
argument to work_in_disk() is False. This commit will provide a
fake string as the node_uuid for the function.
Change-Id: I03563ce0bda96069173060b412293a0a83101e2e
Closes-bug: #1417837
Explain that the 'spacing' argument takes number of seconds. So
'spacing=5' means to run every 5 seconds.
Change-Id: I3b58fbe5c0adfd7f659d6c098533804bbf00d778
Signed-off-by: John L. Villalovos <john.l.villalovos@intel.com>
This updates the docstring for the parallel parameter to make it more
obvious what a value of False means; that it will cause the conductor's
other periodic tasks to be blocked.
Change-Id: Idc4504fdf5b08095f52d21ad938496c88daab742
This change adds all components on proliantutils module
to third_party_driver_mocks. This enables the ilo driver
tests to use the proliantutils module when it is available, and
use the mocks when proliantutils module is not available. This
commit modifies all the ilo driver tests to use the imported
proliantutils module (rather than mocking it completely).
Change-Id: Ief88b194374585c7cfc3c3804b4ea04620fe21e7
Closes-bug: 1416421
This adds documentation on the parallel argument that may be passed to
the driver_periodic_task decorator, and the potential pitfalls of it
being False.
Change-Id: Ib3e25fda2c90c2f68de5878ae353cf55e05fdb28
Implements: blueprint driver-periodic-tasks
