ee5d4942a1
The old code blindly required power status even if the power action failed. Now, it will retry the power action only when it detects a retryable failure, and will only poll for power status if the power action is successful. This patch also moves the logic for handling waiting for power status into the conductor so that the logic is standardised between drivers. Change-Id: Ib48056e05d359848386ac057b58921f40b7bdd60 Co-Authored-By: Sam Betts <sam@code-smash.net> Related-Bug: #1675529 Closes-Bug: #1692895
59 lines
2.8 KiB
Python
59 lines
2.8 KiB
Python
# Copyright 2016 Intel Corporation
|
|
#
|
|
# Copyright 2013 International Business Machines Corporation
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from oslo_config import cfg
|
|
|
|
from ironic.common.i18n import _
|
|
|
|
opts = [
|
|
cfg.IntOpt('command_retry_timeout',
|
|
default=60,
|
|
help=_('Maximum time in seconds to retry, retryable IPMI '
|
|
'operations. For example if the requested action fails '
|
|
'because the BMC is busy. There is a tradeoff when '
|
|
'setting this value. Setting this too low may cause '
|
|
'older BMCs to crash and require a hard reset. However, '
|
|
'setting too high can cause the sync power state '
|
|
'periodic task to hang when there are slow or '
|
|
'unresponsive BMCs.')),
|
|
cfg.IntOpt('retry_timeout',
|
|
help=_('Maximum time in seconds to retry IPMI operations. '
|
|
'There is a tradeoff when setting this value. Setting '
|
|
'this too low may cause older BMCs to crash and require '
|
|
'a hard reset. However, setting too high can cause the '
|
|
'sync power state periodic task to hang when there are '
|
|
'slow or unresponsive BMCs.'),
|
|
deprecated_for_removal=True,
|
|
deprecated_reason=_('Option ipmi.command_retry_timeout should '
|
|
'be used to define IPMI command retries '
|
|
'and option '
|
|
'conductor.power_state_change_timeout '
|
|
'should be use to define timeout value for '
|
|
'waiting for power operations to '
|
|
'complete')),
|
|
cfg.IntOpt('min_command_interval',
|
|
default=5,
|
|
help=_('Minimum time, in seconds, between IPMI operations '
|
|
'sent to a server. There is a risk with some hardware '
|
|
'that setting this too low may cause the BMC to crash. '
|
|
'Recommended setting is 5 seconds.')),
|
|
]
|
|
|
|
|
|
def register_opts(conf):
|
|
conf.register_opts(opts, group='ipmi')
|