CI: Add openstack-tox-pep8 job, fix pep8 failures

Since I8f5338b7eee31f1b8bc3e783d10666e3092a6540 we have not been running
pep8 jobs in CI. This change fixes the issues introduced since then, and
adds the job back.

Unlike the original change, we are not using the openstack-python3-jobs
template since it would use py38 on this branch.

Change-Id: Ie15019f91b9e7b7f8cf97b628886f6b0beeb24fa
(cherry picked from commit 610433b11ba3819869a892489546d9f8b2b743c2)

doc/source/configuration/reference/hosts.rst

@@ -1414,4 +1414,4 @@ using journald defaults). See `journald documentation
 for more details.
 
 Should you wish to disable this feature, you can set ``journald_storage`` to
-``volatile``.
+``volatile``.

kayobe/cli/commands.py

@@ -731,7 +731,8 @@ class SeedServiceDeploy(KollaAnsibleMixin, KayobeAnsibleMixin, VaultMixin,
         playbooks = _build_playbook_list(
             "seed-deploy-containers")
         extra_vars = {"kayobe_action": "deploy"}
-        self.run_kayobe_playbooks(parsed_args, playbooks, extra_vars=extra_vars)
+        self.run_kayobe_playbooks(parsed_args, playbooks,
+                                  extra_vars=extra_vars)
         self.generate_kolla_ansible_config(parsed_args, service_config=False,
                                            bifrost_config=True)
 
@@ -740,10 +741,12 @@ class SeedServiceDeploy(KollaAnsibleMixin, KayobeAnsibleMixin, VaultMixin,
             "seed-credentials",
             "seed-introspection-rules",
             "dell-switch-bmp")
-        self.run_kayobe_playbooks(parsed_args, playbooks, extra_vars=extra_vars)
+        self.run_kayobe_playbooks(parsed_args, playbooks,
+                                  extra_vars=extra_vars)
+
 
 class SeedServiceDestroy(KollaAnsibleMixin, KayobeAnsibleMixin, VaultMixin,
-                        Command):
+                         Command):
     """Destroy the seed services.
 
     * Destroys user defined containers
@@ -762,13 +765,15 @@ class SeedServiceDestroy(KollaAnsibleMixin, KayobeAnsibleMixin, VaultMixin,
         self.generate_kolla_ansible_config(parsed_args, service_config=False,
                                            bifrost_config=False)
         extra_args = ["--yes-i-really-really-mean-it"]
-        self.run_kolla_ansible_seed(parsed_args, "destroy", extra_args=extra_args)
+        self.run_kolla_ansible_seed(parsed_args, "destroy",
+                                    extra_args=extra_args)
 
         extra_vars = {"kayobe_action": "destroy"}
         playbooks = _build_playbook_list(
             "seed-deploy-containers",
             "docker-registry")
-        self.run_kayobe_playbooks(parsed_args, playbooks, extra_vars=extra_vars)
+        self.run_kayobe_playbooks(parsed_args, playbooks,
+                                  extra_vars=extra_vars)
 
     def get_parser(self, prog_name):
         parser = super(SeedServiceDestroy, self).get_parser(prog_name)
@@ -779,6 +784,7 @@ class SeedServiceDestroy(KollaAnsibleMixin, KayobeAnsibleMixin, VaultMixin,
                                 "permanently destroy all services and data.")
         return parser
 
+
 class SeedServiceUpgrade(KollaAnsibleMixin, KayobeAnsibleMixin, VaultMixin,
                          Command):
     """Upgrade the seed services.
@@ -800,7 +806,8 @@ class SeedServiceUpgrade(KollaAnsibleMixin, KayobeAnsibleMixin, VaultMixin,
         playbooks = _build_playbook_list(
             "seed-deploy-containers")
         extra_vars = {"kayobe_action": "deploy"}
-        self.run_kayobe_playbooks(parsed_args, playbooks, extra_vars=extra_vars)
+        self.run_kayobe_playbooks(parsed_args, playbooks,
+                                  extra_vars=extra_vars)
         self.generate_kolla_ansible_config(parsed_args, service_config=False,
                                            bifrost_config=True)
 
@@ -1896,6 +1903,7 @@ class NetworkConnectivityCheck(KayobeAnsibleMixin, VaultMixin, Command):
         playbooks = _build_playbook_list("network-connectivity")
         self.run_kayobe_playbooks(parsed_args, playbooks)
 
+
 class BaremetalComputeRegister(KayobeAnsibleMixin, VaultMixin, Command):
     """Register baremetal compute nodes in Ironic."""
 
@@ -1915,7 +1923,8 @@ class BaremetalComputeInspect(KayobeAnsibleMixin, VaultMixin, Command):
         self.run_kayobe_playbooks(parsed_args, playbooks)
 
 
-class BaremetalComputeIntrospectionDataSave(KayobeAnsibleMixin, VaultMixin, Command):
+class BaremetalComputeIntrospectionDataSave(KayobeAnsibleMixin, VaultMixin,
+                                            Command):
     """Save hardware introspection data for the baremetal compute nodes.
 
     Save hardware introspection data from the overcloud's ironic inspector

zuul.d/project.yaml

@@ -34,6 +34,7 @@
         - kayobe-seed-vm-ubuntu-jammy
         - kayobe-infra-vm-rocky9
         - kayobe-infra-vm-ubuntu-jammy
+        - openstack-tox-pep8
         - openstack-tox-py39
         - openstack-tox-py310
         - openstack-tox-py311