Merge "Replace deprecated library function os.popen() with subprocess"

This commit is contained in:
Jenkins 2016-01-14 21:13:56 +00:00 committed by Gerrit Code Review
commit ecb569dc54

@ -15,6 +15,7 @@
from __future__ import unicode_literals
import os
import subprocess
import sys
import pbr.version
@ -158,8 +159,10 @@ man_pages = []
# If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format.
git_cmd = "git log --pretty=format:'%ad, commit %h' --date=local -n1"
html_last_updated_fmt = os.popen(git_cmd).read()
git_cmd = ["git", "log", "--pretty=format:'%ad, commit %h'", "--date=local",
"-n1"]
html_last_updated_fmt = subprocess.Popen(
git_cmd, stdout=subprocess.PIPE).communicate()[0]
# If true, SmartyPants will be used to convert quotes and dashes to
# typographically correct entities.