openstack/mistral
Code Issues Proposed changes

Merge "Fix invalid assert states"

Browse Source
This commit is contained in:
Zuul 2019-08-08 09:31:01 +00:00 committed by Gerrit Code Review
commit 058b034497
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mistral/tests/unit/db/v2/test_sqlalchemy_db_api.py
View File

@ -3036,7 +3036,7 @@ class ResourceMemberTest(SQLAlchemyTest):
'workflow',
)
self.assertTrue(2, len(fetched))
self.assertEqual(2, len(fetched))
def test_get_resource_members_not_owner(self):
created = db_api.create_resource_member(RESOURCE_MEMBERS[0])
@ -3050,7 +3050,7 @@ class ResourceMemberTest(SQLAlchemyTest):
'workflow',
)
self.assertTrue(1, len(fetched))
self.assertEqual(1, len(fetched))
self.assertEqual(created, fetched[0])
def test_update_resource_member_by_member(self):

8
mistral/tests/unit/engine/test_direct_workflow.py
View File

@ -91,7 +91,7 @@ class DirectWorkflowEngineTest(base.EngineTestCase):
self.await_task_success(task1.id)
self.await_task_success(task2.id)
self.assertTrue(wf_ex.state, states.ERROR)
self.assertEqual(wf_ex.state, states.SUCCESS)
def test_condition_transition_not_triggering(self):
wf_text = """---
@ -132,7 +132,7 @@ class DirectWorkflowEngineTest(base.EngineTestCase):
self.await_task_error(task1.id)
self.assertTrue(wf_ex.state, states.ERROR)
self.assertEqual(wf_ex.state, states.ERROR)
def test_change_state_after_success(self):
wf_text = """
@ -224,7 +224,7 @@ class DirectWorkflowEngineTest(base.EngineTestCase):
wf_ex = self._run_workflow(wf_text)
self.assertIn('Invalid input', wf_ex.state_info)
self.assertTrue(wf_ex.state, states.ERROR)
self.assertEqual(wf_ex.state, states.ERROR)
def test_wrong_first_task_input(self):
wf_text = """
@ -265,7 +265,7 @@ class DirectWorkflowEngineTest(base.EngineTestCase):
# TODO(dzimine): Catch tasks caused error, and set them to ERROR:
# TODO(dzimine): self.assertTrue(task_ex.state, states.ERROR)
self.assertTrue(wf_ex.state, states.ERROR)
self.assertEqual(wf_ex.state, states.ERROR)
self.assertIn("Failed to find action", wf_ex.state_info)
def test_wrong_action_first_task(self):