openstack/openstacksdk
Code Issues Proposed changes

exception: Correct argument

Browse Source 
There were multiple calls to subclasses of 'SDKException' that were
providing a 'msg' kwarg. This doesn't exist. Instead, the parameter is
called 'message'. Correct this by using positional args instead.

Change-Id: Id425b9a57033c89b8a8466a32ab202cdf7556cb2
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane 2021-03-25 17:59:08 +00:00
parent f3f250e9b1
commit 58270810ee
4 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstack/accelerator/v2/deployable.py
View File

@ -52,11 +52,13 @@ class Deployable(resource.Resource):
# The baremetal proxy defaults to retrying on conflict, allow # The baremetal proxy defaults to retrying on conflict, allow
# overriding it via an explicit retry_on_conflict=False. # overriding it via an explicit retry_on_conflict=False.
kwargs['retriable_status_codes'] = retriable_status_codes - {409} kwargs['retriable_status_codes'] = retriable_status_codes - {409}
try: try:
call = getattr(session, method.lower()) call = getattr(session, method.lower())
except AttributeError: except AttributeError:
raise exceptions.ResourceFailure( raise exceptions.ResourceFailure(
msg="Invalid commit method: %s" % method) "Invalid commit method: %s" % method)
request.url = request.url + "/program" request.url = request.url + "/program"
response = call(request.url, json=request.body, response = call(request.url, json=request.body,
headers=request.headers, microversion=microversion, headers=request.headers, microversion=microversion,

2
openstack/block_storage/v2/backup.py
View File

@ -122,7 +122,7 @@ class Backup(resource.Resource):
else: else:
# Just for safety of the implementation (since PUT removed) # Just for safety of the implementation (since PUT removed)
raise exceptions.ResourceFailure( raise exceptions.ResourceFailure(
msg="Invalid create method: %s" % self.create_method) "Invalid create method: %s" % self.create_method)
has_body = (self.has_body if self.create_returns_body is None has_body = (self.has_body if self.create_returns_body is None
else self.create_returns_body) else self.create_returns_body)

2
openstack/block_storage/v3/backup.py
View File

@ -132,7 +132,7 @@ class Backup(resource.Resource):
else: else:
# Just for safety of the implementation (since PUT removed) # Just for safety of the implementation (since PUT removed)
raise exceptions.ResourceFailure( raise exceptions.ResourceFailure(
msg="Invalid create method: %s" % self.create_method) "Invalid create method: %s" % self.create_method)
has_body = (self.has_body if self.create_returns_body is None has_body = (self.has_body if self.create_returns_body is None
else self.create_returns_body) else self.create_returns_body)

6
openstack/resource.py
View File

@ -1380,7 +1380,7 @@ class Resource(dict):
microversion=microversion, params=params) microversion=microversion, params=params)
else: else:
raise exceptions.ResourceFailure( raise exceptions.ResourceFailure(
msg="Invalid create method: %s" % self.create_method) "Invalid create method: %s" % self.create_method)
has_body = (self.has_body if self.create_returns_body is None has_body = (self.has_body if self.create_returns_body is None
else self.create_returns_body) else self.create_returns_body)
@ -1435,7 +1435,7 @@ class Resource(dict):
method = session.post method = session.post
else: else:
raise exceptions.ResourceFailure( raise exceptions.ResourceFailure(
msg="Invalid create method: %s" % cls.create_method) "Invalid create method: %s" % cls.create_method)
body = [] body = []
resources = [] resources = []
@ -1625,7 +1625,7 @@ class Resource(dict):
call = getattr(session, method.lower()) call = getattr(session, method.lower())
except AttributeError: except AttributeError:
raise exceptions.ResourceFailure( raise exceptions.ResourceFailure(
msg="Invalid commit method: %s" % method) "Invalid commit method: %s" % method)
response = call(request.url, json=request.body, response = call(request.url, json=request.body,
headers=request.headers, microversion=microversion, headers=request.headers, microversion=microversion,