openstack/openstacksdk
Code Issues Proposed changes

Fix function test for compute images

Browse Source 
The functional test for compute image metadata did not
expect to get anything back for some reason.

Partial-bug: #1665495

Change-Id: If2d0e0a402bf4fc530187ec07dfd3f69057104bf
This commit is contained in:
Terry Howe 2017-02-17 07:44:34 -07:00
parent 645f06d050
commit 78d1a2400d
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
openstack/tests/functional/compute/v2/test_image.py
View File

@ -73,13 +73,14 @@ class TestImage(base.BaseFunctionalTest):
# set empty metadata # set empty metadata
self.conn.compute.set_image_metadata(image, k0='') self.conn.compute.set_image_metadata(image, k0='')
image = self.conn.compute.get_image_metadata(image) image = self.conn.compute.get_image_metadata(image)
self.assertFalse(image.metadata) self.assertIn('k0', image.metadata)
self.assertEqual('', image.metadata['k0'])
# set metadata # set metadata
self.conn.compute.set_image_metadata(image, k1='v1') self.conn.compute.set_image_metadata(image, k1='v1')
image = self.conn.compute.get_image_metadata(image) image = self.conn.compute.get_image_metadata(image)
self.assertTrue(image.metadata) self.assertTrue(image.metadata)
self.assertEqual(1, len(image.metadata)) self.assertEqual(2, len(image.metadata))
self.assertIn('k1', image.metadata) self.assertIn('k1', image.metadata)
self.assertEqual('v1', image.metadata['k1']) self.assertEqual('v1', image.metadata['k1'])
@ -87,7 +88,7 @@ class TestImage(base.BaseFunctionalTest):
self.conn.compute.set_image_metadata(image, k2='v2') self.conn.compute.set_image_metadata(image, k2='v2')
image = self.conn.compute.get_image_metadata(image) image = self.conn.compute.get_image_metadata(image)
self.assertTrue(image.metadata) self.assertTrue(image.metadata)
self.assertEqual(2, len(image.metadata)) self.assertEqual(3, len(image.metadata))
self.assertIn('k1', image.metadata) self.assertIn('k1', image.metadata)
self.assertEqual('v1', image.metadata['k1']) self.assertEqual('v1', image.metadata['k1'])
self.assertIn('k2', image.metadata) self.assertIn('k2', image.metadata)
@ -97,7 +98,7 @@ class TestImage(base.BaseFunctionalTest):
self.conn.compute.set_image_metadata(image, k1='v1.1') self.conn.compute.set_image_metadata(image, k1='v1.1')
image = self.conn.compute.get_image_metadata(image) image = self.conn.compute.get_image_metadata(image)
self.assertTrue(image.metadata) self.assertTrue(image.metadata)
self.assertEqual(2, len(image.metadata)) self.assertEqual(3, len(image.metadata))
self.assertIn('k1', image.metadata) self.assertIn('k1', image.metadata)
self.assertEqual('v1.1', image.metadata['k1']) self.assertEqual('v1.1', image.metadata['k1'])
self.assertIn('k2', image.metadata) self.assertIn('k2', image.metadata)