diff --git a/openstack/tests/unit/cloud/test_fwaas.py b/openstack/tests/unit/cloud/test_fwaas.py index 4ad163d3c..bd8efdfe6 100644 --- a/openstack/tests/unit/cloud/test_fwaas.py +++ b/openstack/tests/unit/cloud/test_fwaas.py @@ -226,25 +226,28 @@ class TestFirewallRule(FirewallTestCase): filters = {'project_id': self.mock_firewall_rule['project_id']} updated = self.mock_firewall_rule.copy() updated.update(params) - _find = self.cloud.network.find_firewall_rule - self.cloud.network.find_firewall_rule = Mock( - return_value=self.mock_firewall_rule) + updated_dict = self._mock_firewall_rule_attrs.copy() + updated_dict.update(params) self.register_uris([ - dict(method='PUT', - uri=self._make_mock_url('firewall_rules', - self.firewall_rule_id), - json={'firewall_rule': updated}) + dict( + method='GET', + uri=self._make_mock_url( + 'firewall_rules', self.firewall_rule_name), + json={'firewall_rule': self._mock_firewall_rule_attrs}), + dict( + method='PUT', + uri=self._make_mock_url( + 'firewall_rules', self.firewall_rule_id), + json={'firewall_rule': updated_dict}, + validate={ + 'json': {'firewall_rule': params}, + }) ]) - self.assertDictEqual(updated, - self.cloud.update_firewall_rule( - self.firewall_rule_name, filters, **params)) + updated_rule = self.cloud.update_firewall_rule( + self.firewall_rule_name, filters, **params) + self.assertDictEqual(updated, updated_rule) self.assert_calls() - self.cloud.network.find_firewall_rule.assert_called_once_with( - self.firewall_rule_name, ignore_missing=False, **filters) - # restore - self.cloud.network.find_firewall_rule = _find - class TestFirewallPolicy(FirewallTestCase): firewall_policy_id = '78d05d20-d406-41ec-819d-06b65c2684e4'