openstack/openstacksdk
Code Issues Proposed changes

Remove unsupported telemetry create_sample method

Browse Source 
Telemetry create_sample support was removed a while back, but it
is still availble in the proxy.  It does not appear to be supported
in the current API documentation, so remove it.  Fix the functional
test while I'm at it.

Partial-bug: #1665495

Change-Id: I49f7bd59335603284e7ed64ce83c0152f6c5ce6f
This commit is contained in:
Terry Howe 2017-02-22 11:22:59 -07:00
parent f4e4d1496f
commit 96dc965381
3 changed files with 3 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
openstack/telemetry/v2/_proxy.py
View File

@ -111,18 +111,6 @@ class Proxy(proxy2.BaseProxy):
"""
return self._list(_resource.Resource, paginated=False, **query)
def create_sample(self, **attrs):
"""Create a new sample from attributes
:param dict attrs: Keyword arguments which will be used to create
a :class:`~openstack.telemetry.v2.sample.Sample`,
comprised of the properties on the Sample class.
:returns: The results of sample creation
:rtype: :class:`~openstack.telemetry.v2.sample.Sample`
"""
return self._create(sample.Sample, **attrs)
def find_sample(self, name_or_id, ignore_missing=True):
"""Find a single sample

24
openstack/tests/functional/telemetry/v2/test_sample.py
View File

@ -20,25 +20,7 @@ from openstack.tests.functional import base
"Metering service does not exist")
class TestSample(base.BaseFunctionalTest):
meter = None
sample = None
@classmethod
def setUpClass(cls):
super(TestSample, cls).setUpClass()
cls.meter = next(cls.conn.telemetry.meters())
resource = next(cls.conn.telemetry.resources())
sot = cls.conn.telemetry.create_sample(
counter_name=cls.meter.name,
meter=cls.meter.name,
counter_type='gauge',
counter_unit='instance',
counter_volume=1.0,
resource_id=resource.id,
)
assert isinstance(sot, sample.Sample)
cls.sample = sot
def test_list(self):
ids = [o.id for o in self.conn.telemetry.samples(self.meter)]
self.assertIn(self.sample.id, ids)
for meter in self.conn.telemetry.meters():
sot = next(self.conn.telemetry.samples(meter))
assert isinstance(sot, sample.Sample)

3
openstack/tests/unit/telemetry/v2/test_proxy.py
View File

@ -47,9 +47,6 @@ class TestTelemetryProxy(test_proxy_base2.TestProxyBase):
self.verify_list(self.proxy.resources, resource.Resource,
paginated=False)
def test_sample_create_attrs(self):
self.verify_create(self.proxy.create_sample, sample.Sample)
def test_sample_find(self):
self.verify_find(self.proxy.find_sample, sample.Sample)