
There is no need to construct a cloud individually in each unit test. Further more, we can now just use the enable-inner-exception interface introduced a few patches ago. Change-Id: Ia45a47ec243c917ab05b5a2f95c449b9e8d1da68
142 lines
5.5 KiB
Python
142 lines
5.5 KiB
Python
# Licensed under the Apache License, Version 2.0 (the 'License');
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import mock
|
|
import testtools
|
|
|
|
import shade
|
|
from shade.tests.unit import base
|
|
|
|
|
|
class TestNetwork(base.TestCase):
|
|
|
|
@mock.patch.object(shade.OpenStackCloud, 'neutron_client')
|
|
def test_create_network(self, mock_neutron):
|
|
self.cloud.create_network("netname")
|
|
mock_neutron.create_network.assert_called_with(
|
|
body=dict(
|
|
network=dict(
|
|
name='netname',
|
|
shared=False,
|
|
admin_state_up=True
|
|
)
|
|
)
|
|
)
|
|
|
|
@mock.patch.object(shade.OpenStackCloud, 'neutron_client')
|
|
def test_create_network_specific_tenant(self, mock_neutron):
|
|
self.cloud.create_network("netname", project_id="project_id_value")
|
|
mock_neutron.create_network.assert_called_with(
|
|
body=dict(
|
|
network=dict(
|
|
name='netname',
|
|
shared=False,
|
|
admin_state_up=True,
|
|
tenant_id="project_id_value",
|
|
)
|
|
)
|
|
)
|
|
|
|
@mock.patch.object(shade.OpenStackCloud, 'neutron_client')
|
|
def test_create_network_external(self, mock_neutron):
|
|
self.cloud.create_network("netname", external=True)
|
|
mock_neutron.create_network.assert_called_with(
|
|
body=dict(
|
|
network={
|
|
'name': 'netname',
|
|
'shared': False,
|
|
'admin_state_up': True,
|
|
'router:external': True
|
|
}
|
|
)
|
|
)
|
|
|
|
@mock.patch.object(shade.OpenStackCloud, 'neutron_client')
|
|
def test_create_network_provider(self, mock_neutron):
|
|
provider_opts = {'physical_network': 'mynet',
|
|
'network_type': 'vlan',
|
|
'segmentation_id': 'vlan1'}
|
|
self.cloud.create_network("netname", provider=provider_opts)
|
|
mock_neutron.create_network.assert_called_once_with(
|
|
body=dict(
|
|
network={
|
|
'name': 'netname',
|
|
'shared': False,
|
|
'admin_state_up': True,
|
|
'provider:physical_network':
|
|
provider_opts['physical_network'],
|
|
'provider:network_type':
|
|
provider_opts['network_type'],
|
|
'provider:segmentation_id':
|
|
provider_opts['segmentation_id'],
|
|
}
|
|
)
|
|
)
|
|
|
|
@mock.patch.object(shade.OpenStackCloud, 'neutron_client')
|
|
def test_create_network_provider_ignored_value(self, mock_neutron):
|
|
provider_opts = {'physical_network': 'mynet',
|
|
'network_type': 'vlan',
|
|
'segmentation_id': 'vlan1',
|
|
'should_not_be_passed': 1}
|
|
self.cloud.create_network("netname", provider=provider_opts)
|
|
mock_neutron.create_network.assert_called_once_with(
|
|
body=dict(
|
|
network={
|
|
'name': 'netname',
|
|
'shared': False,
|
|
'admin_state_up': True,
|
|
'provider:physical_network':
|
|
provider_opts['physical_network'],
|
|
'provider:network_type':
|
|
provider_opts['network_type'],
|
|
'provider:segmentation_id':
|
|
provider_opts['segmentation_id'],
|
|
}
|
|
)
|
|
)
|
|
|
|
def test_create_network_provider_wrong_type(self):
|
|
provider_opts = "invalid"
|
|
with testtools.ExpectedException(
|
|
shade.OpenStackCloudException,
|
|
"Parameter 'provider' must be a dict"
|
|
):
|
|
self.cloud.create_network("netname", provider=provider_opts)
|
|
|
|
@mock.patch.object(shade.OpenStackCloud, 'get_network')
|
|
@mock.patch.object(shade.OpenStackCloud, 'neutron_client')
|
|
def test_delete_network(self, mock_neutron, mock_get):
|
|
mock_get.return_value = dict(id='net-id', name='test-net')
|
|
self.assertTrue(self.cloud.delete_network('test-net'))
|
|
mock_get.assert_called_once_with('test-net')
|
|
mock_neutron.delete_network.assert_called_once_with(network='net-id')
|
|
|
|
@mock.patch.object(shade.OpenStackCloud, 'get_network')
|
|
def test_delete_network_not_found(self, mock_get):
|
|
mock_get.return_value = None
|
|
self.assertFalse(self.cloud.delete_network('test-net'))
|
|
mock_get.assert_called_once_with('test-net')
|
|
|
|
@mock.patch.object(shade.OpenStackCloud, 'get_network')
|
|
@mock.patch.object(shade.OpenStackCloud, 'neutron_client')
|
|
def test_delete_network_exception(self, mock_neutron, mock_get):
|
|
mock_get.return_value = dict(id='net-id', name='test-net')
|
|
mock_neutron.delete_network.side_effect = Exception()
|
|
with testtools.ExpectedException(
|
|
shade.OpenStackCloudException,
|
|
"Error deleting network test-net"
|
|
):
|
|
self.cloud.delete_network('test-net')
|
|
mock_get.assert_called_once_with('test-net')
|
|
mock_neutron.delete_network.assert_called_once_with(network='net-id')
|