openstack/puppet-cinder
Code Issues Proposed changes

Refer keystone_authtoken to find credentials

Browse Source 
... because api/os_region_name is not set since [1].
This patch also fixes incorrect lookup about domain parameters.

This patch also removes useless and incorrect handling about keystone
version, so that domain parameters are correctly set.

[1] c2d618cae70ba1be7dd8496ce7665ac3abaf8775

Change-Id: Idaa1c767e8cab645567b920dc9d377abf509ec54
This commit is contained in:
Takashi Kajinami 2020-04-14 20:09:23 +09:00
parent 3b612bba47
commit 29e221fe55
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/puppet/provider/cinder.rb
View File

@ -34,12 +34,10 @@ class Puppet::Provider::Cinder < Puppet::Provider::Openstack
@credentials.password = cinder_credentials['password']
@credentials.project_name = cinder_credentials['project_name']
@credentials.auth_url = auth_endpoint
if cinder_credentials['region_name']
@credentials.region_name = cinder_credentials['region_name']
end
if @credentials.version == '3'
@credentials.user_domain_name = cinder_credentials['user_domain_name']
@credentials.project_domain_name = cinder_credentials['project_domain_name']
if cinder_credentials['region_name']
@credentials.region_name = cinder_credentials['region_name']
end
raise error unless @credentials.set?
Puppet::Provider::Openstack.request(service, action, properties, @credentials)
@ -61,19 +59,22 @@ class Puppet::Provider::Cinder < Puppet::Provider::Openstack
auth_keys.all?{|k| !conf['keystone_authtoken'][k].nil?}
creds = Hash[ auth_keys.map \
{ |k| [k, conf['keystone_authtoken'][k].strip] } ]
if conf['project_domain_name']
creds['project_domain_name'] = conf['project_domain_name']
if conf['keystone_authtoken']['project_domain_name']
creds['project_domain_name'] = conf['keystone_authtoken']['project_domain_name']
else
creds['project_domain_name'] = 'Default'
end
if conf['user_domain_name']
creds['user_domain_name'] = conf['user_domain_name']
if conf['keystone_authtoken']['user_domain_name']
creds['user_domain_name'] = conf['keystone_authtoken']['user_domain_name']
else
creds['user_domain_name'] = 'Default'
end
if conf['DEFAULT'] and conf['DEFAULT']['os_region_name']
creds['region_name'] = conf['DEFAULT']['os_region_name']
if conf['keystone_authtoken']['region_name']
creds['region_name'] = conf['keystone_authtoken']['region_name']
end
return creds
else
raise(Puppet::Error, "File: #{conf_filename} does not contain all " +