openstack/puppet-cinder
Code Issues Proposed changes

Merge "Decouple $sync_db from $enabled"

Browse Source
This commit is contained in:
Jenkins 2015-05-13 15:36:23 +00:00 committed by Gerrit Code Review
commit 83c2fbb14c
2 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/api.pp
View File

@ -172,7 +172,6 @@ class cinder::api (
} }
} }
if $enabled {
if $sync_db { if $sync_db {
Cinder_config<||> ~> Exec['cinder-manage db_sync'] Cinder_config<||> ~> Exec['cinder-manage db_sync']
@ -186,6 +185,8 @@ class cinder::api (
before => Service['cinder-api'], before => Service['cinder-api'],
} }
} }
if $enabled {
if $manage_service { if $manage_service {
$ensure = 'running' $ensure = 'running'
} }

5
spec/classes/cinder_api_spec.rb
View File

@ -183,7 +183,7 @@ describe 'cinder::api' do
is_expected.to contain_service('cinder-api').with_ensure('stopped') is_expected.to contain_service('cinder-api').with_ensure('stopped')
end end
it 'should contain db_sync exec' do it 'should contain db_sync exec' do
is_expected.to_not contain_exec('cinder-manage db_sync') is_expected.to contain_exec('cinder-manage db_sync')
end end
end end
@ -194,6 +194,9 @@ describe 'cinder::api' do
it 'should not change the state of the service' do it 'should not change the state of the service' do
is_expected.to contain_service('cinder-api').without_ensure is_expected.to contain_service('cinder-api').without_ensure
end end
it 'should contain db_sync exec' do
is_expected.to contain_exec('cinder-manage db_sync')
end
end end
describe 'with ratelimits' do describe 'with ratelimits' do