openstack/puppet-cinder
Code Issues Proposed changes

rbd: Purge rbd_cluster_name by default

Browse Source 
... to avoid leaving old value.

Change-Id: I4b8d9ee5330ceca602b4c090d687faff35a5b5db
This commit is contained in:
Takashi Kajinami 2024-03-28 15:14:04 +09:00
parent 08052b3852
commit a17d67766d
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/backend/rbd.pp
View File

@ -145,7 +145,7 @@ define cinder::backend::rbd (
$rbd_cluster_name = basename($rbd_ceph_conf, '.conf')
if $rbd_cluster_name == 'ceph' {
# Do not pass a parameter value in order to avoid service restarts
$rbd_cluster_name_real = undef
$rbd_cluster_name_real = $facts['os_service_default']
} else {
$rbd_cluster_name_real = $rbd_cluster_name
}

1
spec/defines/cinder_backend_rbd_spec.rb
View File

@ -37,6 +37,7 @@ describe 'cinder::backend::rbd' do
is_expected.to contain_cinder_config("#{req_params[:volume_backend_name]}/rados_connection_interval").with_value('<SERVICE DEFAULT>')
is_expected.to contain_cinder_config("#{req_params[:volume_backend_name]}/rados_connection_retries").with_value('<SERVICE DEFAULT>')
is_expected.to contain_cinder_config("#{req_params[:volume_backend_name]}/rbd_store_chunk_size").with_value('<SERVICE DEFAULT>')
is_expected.to contain_cinder_config("#{req_params[:volume_backend_name]}/rbd_cluster_name").with_value('<SERVICE DEFAULT>')
is_expected.to contain_cinder_config("#{req_params[:volume_backend_name]}/report_dynamic_total_capacity").with_value('<SERVICE DEFAULT>')
is_expected.to contain_cinder_config("#{req_params[:volume_backend_name]}/rbd_exclusive_cinder_pool").with_value('<SERVICE DEFAULT>')
is_expected.to contain_cinder_config("#{req_params[:volume_backend_name]}/enable_deferred_deletion").with_value('<SERVICE DEFAULT>')