openstack/puppet-cinder
Code Issues Proposed changes

Add secret flag to netapp_sa_password option

Browse Source 
This adds the secret flag to the netapp_sa_password option so the value
is not inadvertantly disclosed.

Change-Id: I738fc37354816f7ad84e8d1a93acfe3eb6f81091
Closes-Bug: 1333372
This commit is contained in:
Bob Callaway 2014-06-23 14:19:36 -04:00
parent 2553e6d1b2
commit aead0deb16
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/backend/netapp.pp
View File

@ -194,7 +194,7 @@ define cinder::backend::netapp (
"${volume_backend_name}/nfs_shares_config": value => $nfs_shares_config;
"${volume_backend_name}/netapp_copyoffload_tool_path": value => $netapp_copyoffload_tool_path;
"${volume_backend_name}/netapp_controller_ips": value => $netapp_controller_ips;
"${volume_backend_name}/netapp_sa_password": value => $netapp_sa_password;
"${volume_backend_name}/netapp_sa_password": value => $netapp_sa_password, secret => true;
"${volume_backend_name}/netapp_storage_pools": value => $netapp_storage_pools;
"${volume_backend_name}/netapp_webservice_path": value => $netapp_webservice_path;
}

4
spec/classes/cinder_volume_netapp_spec.rb
View File

@ -49,6 +49,10 @@ describe 'cinder::volume::netapp' do
it 'marks netapp_password as secret' do
should contain_cinder_config('DEFAULT/netapp_password').with_secret( true )
end
it 'marks netapp_sa_password as secret' do
should contain_cinder_config('DEFAULT/netapp_sa_password').with_secret( true )
end
end

4
spec/defines/cinder_backend_netapp_spec.rb
View File

@ -51,6 +51,10 @@ describe 'cinder::backend::netapp' do
it 'marks netapp_password as secret' do
should contain_cinder_config("#{params_hash[:volume_backend_name]}/netapp_password").with_secret( true )
end
it 'marks netapp_sa_password as secret' do
should contain_cinder_config("#{params_hash[:volume_backend_name]}/netapp_sa_password").with_secret( true )
end
end