openstack/puppet-cinder
Code Issues Proposed changes

Add missing portset parameter to Svf driver

Browse Source 
This patch adds missing configuration parameter 'storwize_portset'
to Cinder IBM Spectrum virtualize family (Svf) driver.

Change-Id: I0b28036bc04b5c0c59347f70273cf0f82848c829
This commit is contained in:
katarimanoj 2023-01-31 13:33:07 +05:30
parent 7a6db09514
commit d307691c1f
3 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
manifests/backend/ibm_svf.pp
View File

@ -38,6 +38,11 @@
# it to a non-mirror relationship. # it to a non-mirror relationship.
# Defaults to $::os_service_default. # Defaults to $::os_service_default.
# #
# [*storwize_portset*]
# (optional) Specifies the name of the portset in which host is to be
# created.
# Defaults to $::os_service_default.
#
# [*volume_backend_name*] # [*volume_backend_name*]
# (optional) The storage backend name. # (optional) The storage backend name.
# Defaults to the name of the backend # Defaults to the name of the backend
@ -69,6 +74,7 @@ define cinder::backend::ibm_svf (
$storwize_svc_connection_protocol = 'iSCSI', $storwize_svc_connection_protocol = 'iSCSI',
$storwize_svc_iscsi_chap_enabled = $::os_service_default, $storwize_svc_iscsi_chap_enabled = $::os_service_default,
$storwize_svc_retain_aux_volume = $::os_service_default, $storwize_svc_retain_aux_volume = $::os_service_default,
$storwize_portset = $::os_service_default,
$volume_backend_name = $name, $volume_backend_name = $name,
$backend_availability_zone = $::os_service_default, $backend_availability_zone = $::os_service_default,
$extra_options = {}, $extra_options = {},
@ -99,6 +105,7 @@ define cinder::backend::ibm_svf (
"${name}/storwize_svc_allow_tenant_qos": value => $storwize_svc_allow_tenant_qos; "${name}/storwize_svc_allow_tenant_qos": value => $storwize_svc_allow_tenant_qos;
"${name}/storwize_svc_iscsi_chap_enabled": value => $storwize_svc_iscsi_chap_enabled; "${name}/storwize_svc_iscsi_chap_enabled": value => $storwize_svc_iscsi_chap_enabled;
"${name}/storwize_svc_retain_aux_volume": value => $storwize_svc_retain_aux_volume; "${name}/storwize_svc_retain_aux_volume": value => $storwize_svc_retain_aux_volume;
"${name}/storwize_portset": value => $storwize_portset;
} }
if $manage_volume_type { if $manage_volume_type {

5
releasenotes/notes/Add_missing_portset_param_in_ibm_svf_driver-e8559483db6d9652.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
Add ``storwize_portset`` parameter to Cinder IBM Spectrum virtualize
family (Svf) driver.

4
spec/defines/cinder_backend_ibm_svf_spec.rb
View File

@ -25,6 +25,10 @@ describe 'cinder::backend::ibm_svf' do
is_expected.to contain_cinder_config("#{title}/san_login").with_value('Admin') is_expected.to contain_cinder_config("#{title}/san_login").with_value('Admin')
is_expected.to contain_cinder_config("#{title}/san_password").with_value('12345') is_expected.to contain_cinder_config("#{title}/san_password").with_value('12345')
is_expected.to contain_cinder_config("#{title}/storwize_svc_volpool_name").with_value('svfpool') is_expected.to contain_cinder_config("#{title}/storwize_svc_volpool_name").with_value('svfpool')
is_expected.to contain_cinder_config("#{title}/storwize_svc_allow_tenant_qos").with_value('<SERVICE DEFAULT>')
is_expected.to contain_cinder_config("#{title}/storwize_svc_iscsi_chap_enabled").with_value('<SERVICE DEFAULT>')
is_expected.to contain_cinder_config("#{title}/storwize_svc_retain_aux_volume").with_value('<SERVICE DEFAULT>')
is_expected.to contain_cinder_config("#{title}/storwize_portset").with_value('<SERVICE DEFAULT>')
is_expected.to contain_cinder_config("#{title}/backend_availability_zone").with_value('<SERVICE DEFAULT>') is_expected.to contain_cinder_config("#{title}/backend_availability_zone").with_value('<SERVICE DEFAULT>')
end end
end end