Use new openstackclient tag

This looses dependency using the new openstackclient tag, which
requires only packages actually related to openstack CLI.

Also, cinderclient is not required by cinder itself so the support
package tag can be removed.

Depends-on: https://review.opendev.org/899594
Change-Id: Ieb7656f1f9a48086a13ebeb9c5418e800bed790f

manifests/client.pp

@@ -18,7 +18,7 @@ class cinder::client(
   package { 'python-cinderclient':
     ensure => $package_ensure,
     name   => $::cinder::params::client_package,
-    tag    => ['openstack', 'cinder-support-package'],
+    tag    => 'openstack',
   }
 
   include openstacklib::openstackclient

manifests/deps.pp

@@ -78,8 +78,8 @@ class cinder::deps {
   # will have clients available to create resources. This tag handles the
   # openstackclient but indirectly since the client is not available in
   # all catalogs that don't need the client class (like many spec tests)
-  Package<| tag == 'openstack'|>
-  ~> Anchor['cinder::service::end']
+  Package<| tag == 'openstackclient'|>
+  -> Anchor['cinder::service::end']
 
   # Installation or config changes will always restart services.
   Anchor['cinder::install::end'] ~> Anchor['cinder::service::begin']

spec/classes/cinder_client_spec.rb

@@ -23,7 +23,7 @@ describe 'cinder::client' do
       is_expected.to contain_package('python-cinderclient').with(
         :name   => platform_params[:client_package_name],
         :ensure => p[:package_ensure],
-        :tag    => ['openstack', 'cinder-support-package'],
+        :tag    => 'openstack',
       )
     end