4224fdd12e
This patch aim to update our specs test in order to work with the rspec-puppet release 2.0.0, in the mean time, we update rspec syntax in order to be prepared for rspec 3.x move. In details: * Use shared_examples "a Puppet::Error" for puppet::error tests * Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x) * Fix spec tests for rspec-puppet 2.0.0 * Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0 * Clean Gemfile (remove over-specificication of runtime deps of puppetlabs_spec_helper) Change-Id: Id5b428fb518f40cf92cd27078d36f19b6d60226b Card: https://trello.com/c/eHXc1Ryd/4-investigate-the-necessary-change-to-be-rspec-puppet-2-0-0-compliant
105 lines
3.1 KiB
Ruby
105 lines
3.1 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'cinder::backend::netapp' do
|
|
|
|
let(:title) {'hippo'}
|
|
|
|
let :params do
|
|
{
|
|
:volume_backend_name => 'netapp-cdot-nfs',
|
|
:netapp_login => 'netapp',
|
|
:netapp_password => 'password',
|
|
:netapp_server_hostname => '127.0.0.2',
|
|
}
|
|
end
|
|
|
|
let :default_params do
|
|
{
|
|
:netapp_server_port => '80',
|
|
:netapp_size_multiplier => '1.2',
|
|
:netapp_storage_family => 'ontap_cluster',
|
|
:netapp_storage_protocol => 'nfs',
|
|
:netapp_transport_type => 'http',
|
|
:netapp_vfiler => '',
|
|
:netapp_volume_list => '',
|
|
:netapp_vserver => '',
|
|
:expiry_thres_minutes => '720',
|
|
:thres_avl_size_perc_start => '20',
|
|
:thres_avl_size_perc_stop => '60',
|
|
:nfs_shares_config => '/etc/cinder/shares.conf',
|
|
:netapp_copyoffload_tool_path => '',
|
|
:netapp_controller_ips => '',
|
|
:netapp_sa_password => '',
|
|
:netapp_storage_pools => '',
|
|
:netapp_webservice_path => '/devmgr/v2',
|
|
}
|
|
end
|
|
|
|
shared_examples_for 'netapp volume driver' do
|
|
let :params_hash do
|
|
default_params.merge(params)
|
|
end
|
|
|
|
it 'configures netapp volume driver' do
|
|
is_expected.to contain_cinder_config("#{params_hash[:volume_backend_name]}/volume_driver").with_value(
|
|
'cinder.volume.drivers.netapp.common.NetAppDriver')
|
|
params_hash.each_pair do |config,value|
|
|
is_expected.to contain_cinder_config("#{params_hash[:volume_backend_name]}/#{config}").with_value( value )
|
|
end
|
|
end
|
|
|
|
it 'marks netapp_password as secret' do
|
|
is_expected.to contain_cinder_config("#{params_hash[:volume_backend_name]}/netapp_password").with_secret( true )
|
|
end
|
|
|
|
it 'marks netapp_sa_password as secret' do
|
|
is_expected.to contain_cinder_config("#{params_hash[:volume_backend_name]}/netapp_sa_password").with_secret( true )
|
|
end
|
|
end
|
|
|
|
|
|
context 'with default parameters' do
|
|
before do
|
|
params = {}
|
|
end
|
|
|
|
it_configures 'netapp volume driver'
|
|
end
|
|
|
|
context 'with provided parameters' do
|
|
it_configures 'netapp volume driver'
|
|
end
|
|
|
|
context 'with netapp_storage_family eseries' do
|
|
let (:req_params) { params.merge!({
|
|
:netapp_storage_family => 'eseries',
|
|
}) }
|
|
|
|
it { is_expected.to contain_cinder_config("#{req_params[:volume_backend_name]}/use_multipath_for_image_xfer").with_value('true') }
|
|
end
|
|
|
|
context 'with NFS shares provided' do
|
|
let (:req_params) { params.merge!({
|
|
:nfs_shares => ['10.0.0.1:/test1', '10.0.0.2:/test2'],
|
|
:nfs_shares_config => '/etc/cinder/shares.conf',
|
|
}) }
|
|
|
|
it 'writes NFS shares to file' do
|
|
is_expected.to contain_file("#{req_params[:nfs_shares_config]}") \
|
|
.with_content("10.0.0.1:/test1\n10.0.0.2:/test2")
|
|
end
|
|
end
|
|
|
|
context 'with invalid NFS shares provided' do
|
|
before do
|
|
params.merge!({
|
|
:nfs_shares => "not an array",
|
|
:nfs_shares_config => '/etc/cinder/shares.conf',
|
|
})
|
|
end
|
|
|
|
it_raises 'a Puppet::Error', /"not an array" is not an Array. It looks to be a String/
|
|
end
|
|
|
|
end
|