e76e0b5d36
Add ability to use python-pymysql library as backend for MySQL connections. Update acceptance tests to use pyMySQL. Docs: https://wiki.openstack.org/wiki/PyMySQL_evaluation The same implementation as it's done for keystone: https://review.openstack.org/#/c/242134/ Change-Id: Id279377b191363b665e22a86f117410a6f7b480c
116 lines
3.7 KiB
Ruby
116 lines
3.7 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'cinder::db' do
|
|
|
|
shared_examples 'cinder::db' do
|
|
|
|
context 'with default parameters' do
|
|
|
|
it { is_expected.to contain_cinder_config('database/connection').with_value('sqlite:////var/lib/cinder/cinder.sqlite').with_secret(true) }
|
|
it { is_expected.to contain_cinder_config('database/idle_timeout').with_value('<SERVICE DEFAULT>') }
|
|
it { is_expected.to contain_cinder_config('database/min_pool_size').with_value('<SERVICE DEFAULT>') }
|
|
it { is_expected.to contain_cinder_config('database/max_retries').with_value('<SERVICE DEFAULT>') }
|
|
it { is_expected.to contain_cinder_config('database/retry_interval').with_value('<SERVICE DEFAULT>') }
|
|
|
|
end
|
|
|
|
context 'with specific parameters' do
|
|
let :params do
|
|
{ :database_connection => 'mysql+pymysql://cinder:cinder@localhost/cinder',
|
|
:database_idle_timeout => '3601',
|
|
:database_min_pool_size => '2',
|
|
:database_max_retries => '11',
|
|
:database_retry_interval => '11', }
|
|
end
|
|
|
|
it { is_expected.to contain_cinder_config('database/connection').with_value('mysql+pymysql://cinder:cinder@localhost/cinder').with_secret(true) }
|
|
it { is_expected.to contain_cinder_config('database/idle_timeout').with_value('3601') }
|
|
it { is_expected.to contain_cinder_config('database/min_pool_size').with_value('2') }
|
|
it { is_expected.to contain_cinder_config('database/max_retries').with_value('11') }
|
|
it { is_expected.to contain_cinder_config('database/retry_interval').with_value('11') }
|
|
end
|
|
|
|
context 'with postgresql backend' do
|
|
let :params do
|
|
{ :database_connection => 'postgresql://cinder:cinder@localhost/cinder', }
|
|
end
|
|
|
|
it 'install the proper backend package' do
|
|
is_expected.to contain_package('python-psycopg2').with(:ensure => 'present')
|
|
end
|
|
|
|
end
|
|
|
|
context 'with MySQL-python library as backend package' do
|
|
let :params do
|
|
{ :database_connection => 'mysql://cinder:cinder@localhost/cinder', }
|
|
end
|
|
|
|
it { is_expected.to contain_package('python-mysqldb').with(:ensure => 'present') }
|
|
end
|
|
|
|
context 'with incorrect database_connection string' do
|
|
let :params do
|
|
{ :database_connection => 'redis://cinder:cinder@localhost/cinder', }
|
|
end
|
|
|
|
it_raises 'a Puppet::Error', /validate_re/
|
|
end
|
|
|
|
context 'with incorrect pymysql database_connection string' do
|
|
let :params do
|
|
{ :database_connection => 'foo+pymysql://cinder:cinder@localhost/cinder', }
|
|
end
|
|
|
|
it_raises 'a Puppet::Error', /validate_re/
|
|
end
|
|
|
|
end
|
|
|
|
context 'on Debian platforms' do
|
|
let :facts do
|
|
@default_facts.merge({
|
|
:osfamily => 'Debian',
|
|
:operatingsystem => 'Debian',
|
|
:operatingsystemrelease => 'jessie',
|
|
})
|
|
end
|
|
|
|
it_configures 'cinder::db'
|
|
|
|
context 'using pymysql driver' do
|
|
let :params do
|
|
{ :database_connection => 'mysql+pymysql://cinder:cinder@localhost/cinder', }
|
|
end
|
|
|
|
it 'install the proper backend package' do
|
|
is_expected.to contain_package('cinder-backend-package').with(
|
|
:ensure => 'present',
|
|
:name => 'python-pymysql',
|
|
:tag => 'openstack'
|
|
)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'on Redhat platforms' do
|
|
let :facts do
|
|
@default_facts.merge({
|
|
:osfamily => 'RedHat',
|
|
:operatingsystemrelease => '7.1',
|
|
})
|
|
end
|
|
|
|
it_configures 'cinder::db'
|
|
|
|
context 'using pymysql driver' do
|
|
let :params do
|
|
{ :database_connection => 'mysql+pymysql://cinder:cinder@localhost/cinder', }
|
|
end
|
|
|
|
it { is_expected.not_to contain_package('cinder-backend-package') }
|
|
end
|
|
end
|
|
|
|
end
|