openstack/puppet-heat
Code Issues Proposed changes

Validate status of cron resource

Browse Source 
This makes sure that the supported value is used for the parameters
which determine the ensure property of a cron resource type.

This also re-implements the validation of age_type parameter using
the native data type.

Change-Id: Ie3d9c4d3dac3484051be3b9418e833454c0fbd2a
This commit is contained in:
Takashi Kajinami 2023-06-22 16:22:09 +09:00
parent 7d927b9a02
commit c62209b8e7
2 changed files with 12 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
manifests/cron/purge_deleted.pp
View File

@ -51,24 +51,20 @@
# Defaults to undef.
#
class heat::cron::purge_deleted (
$ensure = present,
$minute = 1,
$hour = 0,
$monthday = '*',
$month = '*',
$weekday = '*',
$maxdelay = 0,
$user = $::heat::params::user,
$age = 1,
$age_type = 'days',
$destination = '/var/log/heat/heat-purge_deleted.log',
$batch_size = undef,
Enum['present', 'absent'] $ensure = present,
$minute = 1,
$hour = 0,
$monthday = '*',
$month = '*',
$weekday = '*',
$maxdelay = 0,
$user = $::heat::params::user,
$age = 1,
Enum['days', 'hours', 'minutes', 'seconds'] $age_type = 'days',
$destination = '/var/log/heat/heat-purge_deleted.log',
$batch_size = undef,
) inherits heat::params {
if ! member(['days', 'hours', 'minutes', 'seconds'], $age_type) {
fail('age_type possible values are only days, hours, minutes, or seconds.')
}
if $maxdelay == 0 {
$sleep = ''
} else {

10
spec/classes/heat_cron_purge_deleted_spec.rb
View File

@ -109,16 +109,6 @@ describe 'heat::cron::purge_deleted' do
)
end
end
describe 'when setting a wrong age_type' do
before :each do
params.merge!(
:age_type => 'foobar'
)
end
it_raises 'a Puppet::Error', /age_type possible values are only days, hours, minutes, or seconds./
end
end
on_supported_os({