From bad1441aad14b6d0f726ad9461fe397bfcc20db7 Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <tkajinam@redhat.com>
Date: Thu, 12 Jan 2023 15:23:03 +0900
Subject: [PATCH] hnas: Remove deprecated unused parameter

The manila::share::hitachi_hnas::share_backend_name parameter has been
unused and was formally deprecated during the Zed cycle[1] so can be
removed now.

Also, the wrong example is fixed by this change.

[1] 49291198a3d230e9117f2420c99a38670efe25f8

Change-Id: I405ee83fd03d2bdfee819d5f7a452c8477a9f9ed
---
 manifests/share/hitachi_hnas.pp                    | 14 +-------------
 ...efault-share_backend_name-35673dc1ae9fce46.yaml |  5 +++++
 2 files changed, 6 insertions(+), 13 deletions(-)
 create mode 100644 releasenotes/notes/hnas-remove-default-share_backend_name-35673dc1ae9fce46.yaml

diff --git a/manifests/share/hitachi_hnas.pp b/manifests/share/hitachi_hnas.pp
index dd4649cc..36c028cc 100644
--- a/manifests/share/hitachi_hnas.pp
+++ b/manifests/share/hitachi_hnas.pp
@@ -30,15 +30,9 @@
 #   managing share servers.
 #   Defaults to false.
 #
-# DEPRECATED PARAMETERS
-#
-# [*share_backend_name*]
-#   (optional) Name of the backend in manila.conf that
-#   these settings will reside in
-#
 # === Examples
 #
-#  manila::backend::hds_hnas { 'HITACHI1':
+#  class { 'manila::share::hds_hnas':
 #    driver_handles_share_servers => false,
 #    hitachi_hnas_user => 'supervisor',
 #    hitachi_hnas_password => 'supervisor',
@@ -56,14 +50,8 @@ class manila::share::hitachi_hnas (
   $hitachi_hnas_evs_ip,
   $hitachi_hnas_file_system_name,
   $driver_handles_share_servers = false,
-  # DEPRECAED PARAMETERS
-  $share_backend_name           = undef,
 ) {
 
-  if $share_backend_name != undef {
-    warning('The share_backend_name parameter is deprecated and has no effect.')
-  }
-
   manila::backend::hitachi_hnas { 'DEFAULT':
     driver_handles_share_servers  => $driver_handles_share_servers,
     hitachi_hnas_user             => $hitachi_hnas_user,
diff --git a/releasenotes/notes/hnas-remove-default-share_backend_name-35673dc1ae9fce46.yaml b/releasenotes/notes/hnas-remove-default-share_backend_name-35673dc1ae9fce46.yaml
new file mode 100644
index 00000000..f8fd5ee4
--- /dev/null
+++ b/releasenotes/notes/hnas-remove-default-share_backend_name-35673dc1ae9fce46.yaml
@@ -0,0 +1,5 @@
+---
+upgrade:
+  - |
+    The ``manila::share::hitachi_hnas::share_backend_name`` parameter has been
+    removed.