openstack/puppet-manila
Code Issues Proposed changes

healthcheck: Expose ignore_proxied_requests parameter

Browse Source 
Depends-on: https://review.opendev.org/909807
Change-Id: I95c15c7585f1afd81d03c234637e7a5d08ac04e3
This commit is contained in:
Takashi Kajinami 2024-02-26 01:23:47 +09:00
parent 0669b5cd06
commit 2447fdad14
3 changed files with 39 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
manifests/healthcheck.pp
View File

@ -18,6 +18,10 @@
# healthcheck information.
# Defaults to $facts['os_service_default']
#
# [*ignore_proxied_requests*]
# (Optional) Ignore requests with proxy headers
# Defaults to $facts['os_service_default']
#
# [*disable_by_file_path*]
# (Optional) Check the presence of a file to determine if an application
# is running on a port.
@ -29,20 +33,22 @@
# Defaults to $facts['os_service_default']
#
class manila::healthcheck (
$detailed = $facts['os_service_default'],
$backends = $facts['os_service_default'],
$allowed_source_ranges = $facts['os_service_default'],
$disable_by_file_path = $facts['os_service_default'],
$disable_by_file_paths = $facts['os_service_default'],
$detailed = $facts['os_service_default'],
$backends = $facts['os_service_default'],
$allowed_source_ranges = $facts['os_service_default'],
$ignore_proxied_requests = $facts['os_service_default'],
$disable_by_file_path = $facts['os_service_default'],
$disable_by_file_paths = $facts['os_service_default'],
) {
include manila::deps
oslo::healthcheck { 'manila_config':
detailed => $detailed,
backends => $backends,
allowed_source_ranges => $allowed_source_ranges,
disable_by_file_path => $disable_by_file_path,
disable_by_file_paths => $disable_by_file_paths,
detailed => $detailed,
backends => $backends,
allowed_source_ranges => $allowed_source_ranges,
ignore_proxied_requests => $ignore_proxied_requests,
disable_by_file_path => $disable_by_file_path,
disable_by_file_paths => $disable_by_file_paths,
}
}

5
releasenotes/notes/healthcheck-ignore_proxied_requests-afb188f727cc47b5.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
The new ``manila::healthcheck::ignore_proxied_requests`` parameter has been
added.

33
spec/classes/manila_healthcheck_spec.rb
View File

@ -11,11 +11,12 @@ describe 'manila::healthcheck' do
it 'configures default values' do
is_expected.to contain_oslo__healthcheck('manila_config').with(
:detailed => '<SERVICE DEFAULT>',
:backends => '<SERVICE DEFAULT>',
:allowed_source_ranges => '<SERVICE DEFAULT>',
:disable_by_file_path => '<SERVICE DEFAULT>',
:disable_by_file_paths => '<SERVICE DEFAULT>',
:detailed => '<SERVICE DEFAULT>',
:backends => '<SERVICE DEFAULT>',
:allowed_source_ranges => '<SERVICE DEFAULT>',
:ignore_proxied_requests => '<SERVICE DEFAULT>',
:disable_by_file_path => '<SERVICE DEFAULT>',
:disable_by_file_paths => '<SERVICE DEFAULT>',
)
end
end
@ -23,21 +24,23 @@ describe 'manila::healthcheck' do
context 'with specific parameters' do
let :params do
{
:detailed => true,
:backends => ['disable_by_file'],
:allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'],
:disable_by_file_path => '/etc/manila/healthcheck/disabled',
:disable_by_file_paths => ['8786:/etc/manila/healthcheck/disabled'],
:detailed => true,
:backends => ['disable_by_file'],
:allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'],
:ignore_proxied_requests => false,
:disable_by_file_path => '/etc/manila/healthcheck/disabled',
:disable_by_file_paths => ['8786:/etc/manila/healthcheck/disabled'],
}
end
it 'configures specified values' do
is_expected.to contain_oslo__healthcheck('manila_config').with(
:detailed => true,
:backends => ['disable_by_file'],
:allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'],
:disable_by_file_path => '/etc/manila/healthcheck/disabled',
:disable_by_file_paths => ['8786:/etc/manila/healthcheck/disabled'],
:detailed => true,
:backends => ['disable_by_file'],
:allowed_source_ranges => ['10.0.0.0/24', '10.0.1.0/24'],
:ignore_proxied_requests => false,
:disable_by_file_path => '/etc/manila/healthcheck/disabled',
:disable_by_file_paths => ['8786:/etc/manila/healthcheck/disabled'],
)
end
end