diff --git a/manifests/api.pp b/manifests/api.pp index 5776e618..871300f3 100644 --- a/manifests/api.pp +++ b/manifests/api.pp @@ -99,9 +99,9 @@ class manila::api ( $os_region_name = undef, ) inherits manila::params { - include ::manila::deps - include ::manila::params - include ::manila::policy + include manila::deps + include manila::params + include manila::policy require ::keystone::client if $service_port { @@ -121,7 +121,7 @@ class manila::api ( } if $sync_db { - include ::manila::db::sync + include manila::db::sync } if $enabled { @@ -146,7 +146,7 @@ class manila::api ( } elsif $service_name == 'httpd' { # We need to make sure manila-api/eventlet is stopped before trying to # start apache - include ::apache::params + include apache::params service { 'manila-api': ensure => 'stopped', name => $::manila::params::api_service, @@ -177,7 +177,7 @@ server.") manila_config { 'DEFAULT/auth_strategy': value => $auth_strategy; } - include ::manila::keystone::authtoken + include manila::keystone::authtoken if ($ratelimits != undef) { manila_api_paste_ini { diff --git a/manifests/backend/cephfs.pp b/manifests/backend/cephfs.pp index d7aeba53..02a191cf 100644 --- a/manifests/backend/cephfs.pp +++ b/manifests/backend/cephfs.pp @@ -83,7 +83,7 @@ define manila::backend::cephfs ( $cephfs_protocol_helper_type = 'CEPHFS', ) { - include ::manila::deps + include manila::deps $share_driver = 'manila.share.drivers.cephfs.driver.CephFSDriver' diff --git a/manifests/backend/dellemc_isilon.pp b/manifests/backend/dellemc_isilon.pp index e9533d88..d593ce84 100644 --- a/manifests/backend/dellemc_isilon.pp +++ b/manifests/backend/dellemc_isilon.pp @@ -67,7 +67,7 @@ define manila::backend::dellemc_isilon ( $package_ensure = 'present', ) { - include ::manila::deps + include manila::deps validate_legacy(String, 'validate_string', $emc_nas_password) diff --git a/manifests/backend/dellemc_unity.pp b/manifests/backend/dellemc_unity.pp index 3dd33a91..119c9b02 100644 --- a/manifests/backend/dellemc_unity.pp +++ b/manifests/backend/dellemc_unity.pp @@ -92,7 +92,7 @@ define manila::backend::dellemc_unity ( $package_ensure = 'present', ) { - include ::manila::deps + include manila::deps validate_legacy(String, 'validate_string', $emc_nas_password) diff --git a/manifests/backend/dellemc_vmax.pp b/manifests/backend/dellemc_vmax.pp index 47ce70b3..630512db 100644 --- a/manifests/backend/dellemc_vmax.pp +++ b/manifests/backend/dellemc_vmax.pp @@ -71,7 +71,7 @@ define manila::backend::dellemc_vmax ( $package_ensure = 'present', ) { - include ::manila::deps + include manila::deps validate_legacy(String, 'validate_string', $emc_nas_password) diff --git a/manifests/backend/dellemc_vnx.pp b/manifests/backend/dellemc_vnx.pp index 7babea82..54e9dd81 100644 --- a/manifests/backend/dellemc_vnx.pp +++ b/manifests/backend/dellemc_vnx.pp @@ -91,7 +91,7 @@ define manila::backend::dellemc_vnx ( $package_ensure = 'present', ) { - include ::manila::deps + include manila::deps validate_legacy(String, 'validate_string', $emc_nas_password) diff --git a/manifests/backend/generic.pp b/manifests/backend/generic.pp index 4abbc008..4d8f02a6 100644 --- a/manifests/backend/generic.pp +++ b/manifests/backend/generic.pp @@ -88,7 +88,7 @@ define manila::backend::generic ( $automatic_share_server_cleanup = 'True', ) { - include ::manila::deps + include manila::deps $share_driver = 'manila.share.drivers.generic.GenericShareDriver' diff --git a/manifests/backend/glusterfs.pp b/manifests/backend/glusterfs.pp index cb6e3f03..1ca722fa 100644 --- a/manifests/backend/glusterfs.pp +++ b/manifests/backend/glusterfs.pp @@ -28,7 +28,7 @@ define manila::backend::glusterfs ( $glusterfs_mount_point_base = '$state_path/mnt', ) { - include ::manila::deps + include manila::deps $share_driver = 'manila.share.drivers.glusterfs.GlusterfsShareDriver' manila_config { diff --git a/manifests/backend/glusternative.pp b/manifests/backend/glusternative.pp index f79fcd7d..1650f22e 100644 --- a/manifests/backend/glusternative.pp +++ b/manifests/backend/glusternative.pp @@ -31,8 +31,8 @@ define manila::backend::glusternative ( $package_ensure = 'present', ) { - include ::manila::deps - include ::manila::params + include manila::deps + include manila::params $share_driver = 'manila.share.drivers.glusterfs_native.GlusterfsNativeShareDriver' diff --git a/manifests/backend/glusternfs.pp b/manifests/backend/glusternfs.pp index 054aaf7a..7ab3897e 100644 --- a/manifests/backend/glusternfs.pp +++ b/manifests/backend/glusternfs.pp @@ -42,8 +42,8 @@ define manila::backend::glusternfs ( $package_ensure = 'present', ) { - include ::manila::deps - include ::manila::params + include manila::deps + include manila::params $share_driver = 'manila.share.drivers.glusterfs.GlusterfsShareDriver' diff --git a/manifests/backend/hitachi_hnas.pp b/manifests/backend/hitachi_hnas.pp index 9635f154..857653e7 100644 --- a/manifests/backend/hitachi_hnas.pp +++ b/manifests/backend/hitachi_hnas.pp @@ -61,7 +61,7 @@ define manila::backend::hitachi_hnas ( $package_ensure = 'present', ) { - include ::manila::deps + include manila::deps validate_legacy(String, 'validate_string', $hitachi_hnas_password) diff --git a/manifests/backend/netapp.pp b/manifests/backend/netapp.pp index fc44d429..b0093ac3 100644 --- a/manifests/backend/netapp.pp +++ b/manifests/backend/netapp.pp @@ -120,7 +120,7 @@ define manila::backend::netapp ( $package_ensure = 'present', ) { - include ::manila::deps + include manila::deps validate_legacy(String, 'validate_string', $netapp_password) diff --git a/manifests/backends.pp b/manifests/backends.pp index c6bf5b84..3072754a 100644 --- a/manifests/backends.pp +++ b/manifests/backends.pp @@ -14,7 +14,7 @@ class manila::backends ( $enabled_share_backends = undef ) { - include ::manila::deps + include manila::deps # Maybe this could be extended to dynamically find the enabled names manila_config { diff --git a/manifests/client.pp b/manifests/client.pp index c6904653..3f7fe616 100644 --- a/manifests/client.pp +++ b/manifests/client.pp @@ -11,8 +11,8 @@ class manila::client ( $package_ensure = 'present' ) { - include ::manila::deps - include ::manila::params + include manila::deps + include manila::params package { 'python-manilaclient': ensure => $package_ensure, diff --git a/manifests/compute/nova.pp b/manifests/compute/nova.pp index 25c21c42..8809692c 100644 --- a/manifests/compute/nova.pp +++ b/manifests/compute/nova.pp @@ -111,7 +111,7 @@ class manila::compute::nova ( $nova_admin_auth_url = undef, ) { - include ::manila::deps + include manila::deps if $nova_catalog_info { warning('The nova_catalog_info parameter is deprecated, has no effect and will be removed in a future release.') diff --git a/manifests/config.pp b/manifests/config.pp index 0d936d07..2a41a5f5 100644 --- a/manifests/config.pp +++ b/manifests/config.pp @@ -32,7 +32,7 @@ class manila::config ( $api_paste_ini_config = {}, ) { - include ::manila::deps + include manila::deps validate_legacy(Hash, 'validate_hash', $manila_config) validate_legacy(Hash, 'validate_hash', $api_paste_ini_config) diff --git a/manifests/db.pp b/manifests/db.pp index 9f00815f..f3ea817b 100644 --- a/manifests/db.pp +++ b/manifests/db.pp @@ -62,7 +62,7 @@ class manila::db ( $database_idle_timeout = undef, ) { - include ::manila::deps + include manila::deps if $database_idle_timeout { warning('The database_idle_timeout parameter is deprecated. Please use \ diff --git a/manifests/db/mysql.pp b/manifests/db/mysql.pp index ce42b087..062212c9 100644 --- a/manifests/db/mysql.pp +++ b/manifests/db/mysql.pp @@ -45,7 +45,7 @@ class manila::db::mysql ( $cluster_id = 'localzone', ) { - include ::manila::deps + include manila::deps validate_legacy(String, 'validate_string', $password) diff --git a/manifests/db/postgresql.pp b/manifests/db/postgresql.pp index de0e7f00..3f1d265f 100644 --- a/manifests/db/postgresql.pp +++ b/manifests/db/postgresql.pp @@ -32,7 +32,7 @@ class manila::db::postgresql( $privileges = 'ALL', ) { - include ::manila::deps + include manila::deps ::openstacklib::db::postgresql { 'manila': password_hash => postgresql_password($user, $password), diff --git a/manifests/db/sync.pp b/manifests/db/sync.pp index 9a083b1a..cd4d1295 100644 --- a/manifests/db/sync.pp +++ b/manifests/db/sync.pp @@ -1,8 +1,8 @@ # class manila::db::sync { - include ::manila::params - include ::manila::deps + include manila::params + include manila::deps exec { 'manila-manage db_sync': command => $::manila::params::db_sync_command, diff --git a/manifests/ganesha.pp b/manifests/ganesha.pp index 7bfabb1a..b96dfb63 100644 --- a/manifests/ganesha.pp +++ b/manifests/ganesha.pp @@ -39,7 +39,7 @@ class manila::ganesha ( $ganesha_export_template_dir = '/etc/manila/ganesha-export-templ.d', ) { - include ::manila::deps + include manila::deps manila_config { 'DEFAULT/ganesha_config_dir': value => $ganesha_config_dir; diff --git a/manifests/init.pp b/manifests/init.pp index ca98457f..1e3d3246 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -273,9 +273,9 @@ class manila ( $host = $::os_service_default, ) { - include ::manila::deps - include ::manila::db - include ::manila::params + include manila::deps + include manila::db + include manila::params if $use_ssl { if !$cert_file { diff --git a/manifests/keystone/auth.pp b/manifests/keystone/auth.pp index 9f65be8a..f144aece 100644 --- a/manifests/keystone/auth.pp +++ b/manifests/keystone/auth.pp @@ -131,7 +131,7 @@ class manila::keystone::auth ( $internal_url_v2 = 'http://127.0.0.1:8786/v2/%(tenant_id)s', ) { - include ::manila::deps + include manila::deps # for interface backward compatibility, we can't enforce to set a new parameter # so we take 'password' parameter by default but allow to override it. diff --git a/manifests/keystone/authtoken.pp b/manifests/keystone/authtoken.pp index 4173dfd6..221a973b 100644 --- a/manifests/keystone/authtoken.pp +++ b/manifests/keystone/authtoken.pp @@ -214,7 +214,7 @@ class manila::keystone::authtoken( $service_token_roles_required = $::os_service_default, ) { - include ::manila::deps + include manila::deps if is_service_default($password) { fail('Please set password for manila service user') diff --git a/manifests/logging.pp b/manifests/logging.pp index 15104218..f82aaa43 100644 --- a/manifests/logging.pp +++ b/manifests/logging.pp @@ -119,7 +119,7 @@ class manila::logging( $log_date_format = $::os_service_default, ) { - include ::manila::deps + include manila::deps oslo::log { 'manila_config': debug => $debug, diff --git a/manifests/params.pp b/manifests/params.pp index d8f16e87..95b1a34b 100644 --- a/manifests/params.pp +++ b/manifests/params.pp @@ -4,7 +4,7 @@ # class manila::params { - include ::openstacklib::defaults + include openstacklib::defaults $pyvers = $::openstacklib::defaults::pyvers $client_package = "python${pyvers}-manilaclient" diff --git a/manifests/policy.pp b/manifests/policy.pp index 7c581d09..8c7e8bd6 100644 --- a/manifests/policy.pp +++ b/manifests/policy.pp @@ -28,8 +28,8 @@ class manila::policy ( $policy_path = '/etc/manila/policy.json', ) { - include ::manila::deps - include ::manila::params + include manila::deps + include manila::params validate_legacy(Hash, 'validate_hash', $policies) diff --git a/manifests/quota.pp b/manifests/quota.pp index f6cf849d..818a6a63 100644 --- a/manifests/quota.pp +++ b/manifests/quota.pp @@ -50,7 +50,7 @@ class manila::quota ( $max_age = 0, ) { - include ::manila::deps + include manila::deps manila_config { 'DEFAULT/quota_shares': value => $quota_shares; diff --git a/manifests/rabbitmq.pp b/manifests/rabbitmq.pp index 75baf8ca..05676ddc 100644 --- a/manifests/rabbitmq.pp +++ b/manifests/rabbitmq.pp @@ -37,7 +37,7 @@ class manila::rabbitmq( $port = '5672', ) { - include ::manila::deps + include manila::deps warning('manila::rabbitmq class is deprecated and will be removed in next release. Make other plans to configure rabbitmq resources.') diff --git a/manifests/scheduler.pp b/manifests/scheduler.pp index 6b9d4ade..3b21908e 100644 --- a/manifests/scheduler.pp +++ b/manifests/scheduler.pp @@ -27,8 +27,8 @@ class manila::scheduler ( $manage_service = true ) { - include ::manila::deps - include ::manila::params + include manila::deps + include manila::params Manila_config<||> ~> Service['manila-scheduler'] Manila_api_paste_ini<||> ~> Service['manila-scheduler'] diff --git a/manifests/service_instance.pp b/manifests/service_instance.pp index 7253f62a..94ca4a00 100644 --- a/manifests/service_instance.pp +++ b/manifests/service_instance.pp @@ -104,7 +104,7 @@ define manila::service_instance ( ) { - include ::manila::deps + include manila::deps if $service_instance_network_helper_type { warning('service_instance_network_helper_type is deprecated, has no effect, and will be removed in the future.') diff --git a/manifests/share.pp b/manifests/share.pp index b30c3ae8..b4dae6aa 100644 --- a/manifests/share.pp +++ b/manifests/share.pp @@ -21,8 +21,8 @@ class manila::share ( $manage_service = true ) { - include ::manila::deps - include ::manila::params + include manila::deps + include manila::params Manila_config<||> ~> Service['manila-share'] Manila_api_paste_ini<||> ~> Service['manila-share'] diff --git a/manifests/type.pp b/manifests/type.pp index eb8bf613..9ff19af4 100644 --- a/manifests/type.pp +++ b/manifests/type.pp @@ -45,8 +45,8 @@ define manila::type ( $volume_name = $name - include ::manila::deps - include ::manila::client + include manila::deps + include manila::client # TODO: (xarses) This should be moved to a ruby provider so that among other # reasons, the credential discovery magic can occur like in neutron. diff --git a/manifests/type_set.pp b/manifests/type_set.pp index 66486bfe..9c666c82 100644 --- a/manifests/type_set.pp +++ b/manifests/type_set.pp @@ -38,8 +38,8 @@ define manila::type_set ( $os_region_name = undef, ) { - include ::manila::deps - include ::manila::client + include manila::deps + include manila::client # TODO: (xarses) This should be moved to a ruby provider so that among other # reasons, the credential discovery magic can occur like in neutron. diff --git a/manifests/volume/cinder.pp b/manifests/volume/cinder.pp index cbc7ea0b..ff460223 100644 --- a/manifests/volume/cinder.pp +++ b/manifests/volume/cinder.pp @@ -56,7 +56,7 @@ class manila::volume::cinder ( $cinder_admin_auth_url = 'http://localhost:5000/v3', ) { - include ::manila::deps + include manila::deps manila_config { 'DEFAULT/cinder_catalog_info': value => $cinder_catalog_info; diff --git a/manifests/wsgi/apache.pp b/manifests/wsgi/apache.pp index 9bd1cf2a..62bc618c 100644 --- a/manifests/wsgi/apache.pp +++ b/manifests/wsgi/apache.pp @@ -123,12 +123,12 @@ class manila::wsgi::apache ( $custom_wsgi_process_options = {}, ) { - include ::manila::deps - include ::manila::params - include ::apache - include ::apache::mod::wsgi + include manila::deps + include manila::params + include apache + include apache::mod::wsgi if $ssl { - include ::apache::mod::ssl + include apache::mod::ssl } ::openstacklib::wsgi::apache { 'manila_wsgi': diff --git a/spec/acceptance/basic_manila_spec.rb b/spec/acceptance/basic_manila_spec.rb index cd05457d..0e0eb621 100644 --- a/spec/acceptance/basic_manila_spec.rb +++ b/spec/acceptance/basic_manila_spec.rb @@ -6,11 +6,11 @@ describe 'basic manila' do it 'should work with no errors' do pp= <<-EOS - include ::openstack_integration - include ::openstack_integration::repos - include ::openstack_integration::rabbitmq - include ::openstack_integration::mysql - include ::openstack_integration::keystone + include openstack_integration + include openstack_integration::repos + include openstack_integration::rabbitmq + include openstack_integration::mysql + include openstack_integration::keystone rabbitmq_user { 'manila': admin => true, @@ -28,35 +28,35 @@ describe 'basic manila' do } # Manila resources - class { '::manila::logging': + class { 'manila::logging': debug => true, } - class { '::manila': + class { 'manila': default_transport_url => 'rabbit://manila:an_even_bigger_secret@127.0.0.1:5672/', sql_connection => 'mysql+pymysql://manila:a_big_secret@127.0.0.1/manila?charset=utf8', } - class { '::manila::db::mysql': + class { 'manila::db::mysql': password => 'a_big_secret', } - class { '::manila::keystone::auth': + class { 'manila::keystone::auth': password => 'a_big_secret', password_v2 => 'a_big_secret', } - class { '::manila::client': } - class { '::manila::compute::nova': } - class { '::manila::network::neutron': } - class { '::manila::volume::cinder': } - class { '::manila::keystone::authtoken': + class { 'manila::client': } + class { 'manila::compute::nova': } + class { 'manila::network::neutron': } + class { 'manila::volume::cinder': } + class { 'manila::keystone::authtoken': password => 'a_big_secret', } - class { '::manila::api': + class { 'manila::api': service_name => 'httpd', } - include ::apache - class { '::manila::wsgi::apache': + include apache + class { 'manila::wsgi::apache': ssl => false, } - class { '::manila::scheduler': } + class { 'manila::scheduler': } # missing: backends, share, service_instance EOS diff --git a/spec/classes/manila_api_spec.rb b/spec/classes/manila_api_spec.rb index 60132979..882472b3 100644 --- a/spec/classes/manila_api_spec.rb +++ b/spec/classes/manila_api_spec.rb @@ -153,9 +153,9 @@ describe 'manila::api' do end let :pre_condition do - "include ::apache + "include apache class { 'manila': } - class { '::manila::keystone::authtoken': + class { 'manila::keystone::authtoken': password => 'foo', }" end @@ -175,9 +175,9 @@ describe 'manila::api' do end let :pre_condition do - "include ::apache + "include apache class { 'manila': } - class { '::manila::keystone::authtoken': + class { 'manila::keystone::authtoken': password => 'foo', }" end